From owner-freebsd-current@FreeBSD.ORG Sat Jan 26 14:19:07 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C657493C; Sat, 26 Jan 2013 14:19:07 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E1A4D13D; Sat, 26 Jan 2013 14:19:06 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA12547; Sat, 26 Jan 2013 16:18:59 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Tz6ax-000HxU-9H; Sat, 26 Jan 2013 16:18:59 +0200 Message-ID: <5103E5D1.3070808@FreeBSD.org> Date: Sat, 26 Jan 2013 16:18:57 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130121 Thunderbird/17.0.2 MIME-Version: 1.0 To: John Baldwin Subject: Re: acpi resume related patch References: <510245B5.8070704@FreeBSD.org> <201301250851.25243.jhb@freebsd.org> <5102ADF6.4060202@FreeBSD.org> In-Reply-To: <5102ADF6.4060202@FreeBSD.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2013 14:19:07 -0000 on 25/01/2013 18:08 Andriy Gapon said the following: > on 25/01/2013 15:51 John Baldwin said the following: >> On Friday, January 25, 2013 3:43:33 am Andriy Gapon wrote: >>> >>> If you have ACPI suspend/resume working, if it used to work but stopped working >>> at some time, if it never worked, but you are still hoping, could you please >>> test the following patch and report back? >>> >>> http://svn.freebsd.by/files/acpi-apic-wakeup-final.patch >> >> This will break systems not using the local APIC since you unconditionally >> call lapic_setup() on resume.This was part of the feature of the previous >> code that by using a dummy pic it could register it only when the local APIC >> was used. > > Thank you for drawing my attention to this. I will try to fix this issue. > The reason I want to remove lapic from 'pics' (and I already described it in a > private email) is that Local APIC is a special kind of PIC. It's already > explicitly initialized by APs. Putting it into 'pics' tailq just obfuscates the code. > >> It should also be registered before any of the I/O APICs are by >> the design of the local_apic.c code. > > In fact, as I see in the code, Local APIC is always registered _after_ I/O APICs. > And thus lapic_resume was called after ioapic_resume. > Additionally, currently there is no synchronization between initialization of > Local APICs on APs and initialization of I/O APICs at the wakeup/resume time. > Here is an updated version of the patch: http://people.freebsd.org/~avg/acpi-apic-wakeup.2.patch John, could you please review the PIC-related part? I decided to go back to the current approach while fixing the suspend/resume ordering and also order of registration for Local APIC. Must say that XEN special casing makes apic_setup_io a little bit untidy. Additionally this patch fixes AP Local APIC initialization ordering on i386. In the original patch I changed only amd64 code. -- Andriy Gapon