From owner-freebsd-ports@FreeBSD.ORG Sat Dec 17 21:05:51 2005 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 483C416A420 for ; Sat, 17 Dec 2005 21:05:51 +0000 (GMT) (envelope-from swhetzel@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.197]) by mx1.FreeBSD.org (Postfix) with ESMTP id 918EE43D6A for ; Sat, 17 Dec 2005 21:05:49 +0000 (GMT) (envelope-from swhetzel@gmail.com) Received: by xproxy.gmail.com with SMTP id s9so686811wxc for ; Sat, 17 Dec 2005 13:05:48 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=KdDDcgbxOePJQLeS91HjEorKBgr8wF5thrxLFN9DnBKA0T3c84+eN5cVzmesngtKrpqL8dik++yfw8M4A5onUW5812yQgCNgcHD/QWaJvijYCC22JM5j6mjbC9ltWIK9R5X2mMQn2Y38WTiRSkzULbDW0RITjqq5jhTFMO2Q3Vg= Received: by 10.70.100.5 with SMTP id x5mr2706377wxb; Sat, 17 Dec 2005 13:05:48 -0800 (PST) Received: by 10.70.27.5 with HTTP; Sat, 17 Dec 2005 13:05:48 -0800 (PST) Message-ID: <790a9fff0512171305j45b46593j683be6227366d71c@mail.gmail.com> Date: Sat, 17 Dec 2005 15:05:48 -0600 From: Scot Hetzel To: Brooks Davis In-Reply-To: <20051217203912.GD29053@odin.ac.hmc.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20051217201004.GA845@zaphod.nitro.dk> <1134850440.64549.0.camel@localhost> <20051217203912.GD29053@odin.ac.hmc.edu> Cc: Pav Lucistnik , "Simon L. Nielsen" , freebsd-ports@freebsd.org Subject: Re: Conflicting rc.d script and port dist directory X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2005 21:05:51 -0000 On 12/17/05, Brooks Davis wrote: > On Sat, Dec 17, 2005 at 09:13:59PM +0100, Pav Lucistnik wrote: > > Simon L. Nielsen p=ED?e v so 17. 12. 2005 v 21:10 +0100: > > > Hey, > > > > > > I'm in the process of adding an rc.d script to the security/isakmpd > > > port, but I have run into a problem. > > > > > > I have added "USE_RC_SUBR=3D isakmpd" to the port Makefile and create= d > > > the rc.d script as files/isakmpd.in. > > > > > > The isakmpd distfile extracts the source to isakmpd/ in the the work > > > directory, which the conflicts with the rc.d script generation > > > (SUB_FILES), since it tries to create ${WRKDIR}/${file} as a file. > > > This shows up during make install: > > > > > > [simon@zaphod:isakmpd] sudo make install > > > =3D=3D=3D> Installing for isakmpd-20041207_1 > > > cannot create /data/tmp/porttmp/home/simon/FreeBSD/ports/isakmpd/work= /isakmpd: Is a directory > > > *** Error code 2 > > > > > > So, does anybody have good (and hopefully not to hackish) ideas of > > > what to do? > > > > Yes. Name the script isakmpd.sh.in ... > > > > The framework will add the .sh suffix anyway. > > That would be a hack since we don't want to continue adding .sh... > I don't see this as a hack. Any rc.d script placed in ${WORK} directory should have the .sh extention to avoid conflicts with similar named directories. When the port installs the rc.d script, it should check OSVERSION to determine if the script should be installed/not-installed with the .sh suffix. Scot -- DISCLAIMER: No electrons were mamed while sending this message. Only slightly bruised.