From owner-freebsd-jail@FreeBSD.ORG  Fri Aug  8 17:40:04 2008
Return-Path: <owner-freebsd-jail@FreeBSD.ORG>
Delivered-To: freebsd-jail@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4DE461065674
	for <freebsd-jail@hub.freebsd.org>;
	Fri,  8 Aug 2008 17:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 3CAD78FC14
	for <freebsd-jail@hub.freebsd.org>;
	Fri,  8 Aug 2008 17:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m78He4RN084277
	for <freebsd-jail@freefall.freebsd.org>; Fri, 8 Aug 2008 17:40:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m78He4bc084276;
	Fri, 8 Aug 2008 17:40:04 GMT (envelope-from gnats)
Date: Fri, 8 Aug 2008 17:40:04 GMT
Message-Id: <200808081740.m78He4bc084276@freefall.freebsd.org>
To: freebsd-jail@FreeBSD.org
From: "Mateusz Guzik" <mjguzik@gmail.com>
Cc: 
Subject: Re: kern/126368: Running ktrace/kdump in jail leads to stale jails
X-BeenThere: freebsd-jail@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Mateusz Guzik <mjguzik@gmail.com>
List-Id: "Discussion about FreeBSD jail\(8\)" <freebsd-jail.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-jail>,
	<mailto:freebsd-jail-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-jail>
List-Post: <mailto:freebsd-jail@freebsd.org>
List-Help: <mailto:freebsd-jail-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-jail>,
	<mailto:freebsd-jail-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Aug 2008 17:40:04 -0000

The following reply was made to PR kern/126368; it has been noted by GNATS.

From: "Mateusz Guzik" <mjguzik@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: kern/126368: Running ktrace/kdump in jail leads to stale jails
Date: Fri, 8 Aug 2008 19:30:22 +0200

 Err, I made a mistake. crfree() will be called in case of failure
 (loop starting at line 959), so the following patch should be ok:
 
 --- sys/kern/kern_ktrace.c.orig	2008-08-08 16:37:45.000000000 +0200
 +++ sys/kern/kern_ktrace.c	2008-08-08 19:25:16.000000000 +0200
 @@ -933,12 +933,14 @@
  		error = VOP_WRITE(vp, &auio, IO_UNIT | IO_APPEND, cred);
  	VOP_UNLOCK(vp, 0, td);
  	vn_finished_write(mp);
  	vrele(vp);
  	VFS_UNLOCK_GIANT(vfslocked);
 -	if (!error)
 +	if (!error) {
 +		crfree(cred);
  		return;
 +	}
  	/*
  	 * If error encountered, give up tracing on this vnode.  We defer
  	 * all the vrele()'s on the vnode until after we are finished walking
  	 * the various lists to avoid needlessly holding locks.
  	 */