From owner-svn-ports-head@FreeBSD.ORG  Wed Apr  3 17:35:22 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id D8F04E86;
 Wed,  3 Apr 2013 17:35:22 +0000 (UTC)
 (envelope-from makc@freebsd.org)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
 by mx1.freebsd.org (Postfix) with ESMTP id 61A1A224;
 Wed,  3 Apr 2013 17:35:21 +0000 (UTC)
Received: from mercury.ph.man.ac.uk [130.88.75.175:61825] (HELO/EHLO
 mercury.ph.man.ac.uk, authenticated with LOGIN)
 by mail.issp.ac.ru with ESMTP/inet id r33HZQ0i097621 (using TLSv1/SSLv3,
 with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
 Wed, 3 Apr 2013 21:35:27 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux
 graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict
Date: Wed, 03 Apr 2013 17:36:36 +0000
Message-ID: <2621916.z1b9zmMaju@mercury.ph.man.ac.uk>
User-Agent: KMail/4.10.1 (FreeBSD/9.1-STABLE; KDE/4.10.1; amd64; ; )
In-Reply-To: <20130328030757.GB83712@FreeBSD.org>
References: <201303251359.r2PDxIXf035701@svn.freebsd.org>
 <CAF6rxgkipVS-gneKbOO-zFyUm=W3AeffBDGd2EegcUt8iXufDw@mail.gmail.com>
 <20130328030757.GB83712@FreeBSD.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Eitan Adler <eadler@freebsd.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2013 17:35:22 -0000

On Thu, 28 Mar 2013 03:07:57 +0000 Alexey Dokuchaev wrote:
> On Wed, Mar 27, 2013 at 10:57:34PM -0400, Eitan Adler wrote:
> > On 27 March 2013 22:53, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote:
> > >> New Revision: 315222
> > >> URL: http://svnweb.freebsd.org/changeset/ports/315222
> > >>
> > >> - Remove OPTIONS_DEFINE, if it contains only global options
> > >
> > > Can you elaborate on this one?  Given that there is no clear policy,
> > > personally I've been always including OPTIONS_DEFINE, even if just for,
> > > say, DOCS.
> > 
> > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set
> > globally (e.g., OPTIONS_UNSET= NLS) and not per port.  As such, it can
> > reduce user annoyance if the dialog box is not shown for such options.

and it keeps status quo with old options framework, when DOCS/EXAMPLES were not
usually added to the options list, apparently because bsd.port.mk checked only
for NOPORT* variables.

> Yes, I've heard that reasoning.  I'm not particularly against it, but I
> am also worried about certain inconsistency: it means, that for a port
> with at least one "local" option, users can toggle all of them, while for
> others they had to rely on their /etc/make.conf settings (or defaults).

I agree with you about inconsistency. I'm fine with any policy once it's
settled.

Max