From owner-freebsd-commit  Sat Apr 15 16:40:11 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id QAA07769
          for commit-outgoing; Sat, 15 Apr 1995 16:40:11 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id QAA07756
          for cvs-usrsbin-outgoing; Sat, 15 Apr 1995 16:40:08 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id QAA07750
          ; Sat, 15 Apr 1995 16:40:03 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id QAA05684; Sat, 15 Apr 1995 16:35:54 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199504152335.QAA05684@gndrsh.aac.dev.com>
Subject: Re: cvs commit: src/usr.sbin/bad144 bad144.c
To: bde@zeta.org.au (Bruce Evans)
Date: Sat, 15 Apr 1995 16:35:54 -0700 (PDT)
Cc: CVS-commiters@freefall.cdrom.com, bde@freefall.cdrom.com,
        cvs-usrsbin@freefall.cdrom.com
In-Reply-To: <199504152207.IAA06391@godzilla.zeta.org.au> from "Bruce Evans" at Apr 16, 95 08:07:22 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1471      
Sender: commit-owner@FreeBSD.org
Precedence: bulk

> 
> >  - Avoid overflow in calculation of lseek() offsets.
> >  - Fix format args in strings some more.  %ld and %lu were often reversed and
> >  #ifdefed out strings weren't fixed.
> >  - Don't hard code the raw partition letter or DKBAD*.
> 
> Why does cvs strip leading whitspace in log messages?  The `#ifdefed' line
> is supposed to be indented.

Becuase who ever wrote log_accum.pl thought that is what it should do:
#   
# Iterate over the body of the message collecting information.
#   
while (<STDIN>) {
    chop;                       # Drop the newline
    if (/^Modified Files/) { $state = $STATE_CHANGED; next; }
    if (/^Added Files/)    { $state = $STATE_ADDED;   next; }
    if (/^Removed Files/)  { $state = $STATE_REMOVED; next; }
    if (/^Log Message/)    { $state = $STATE_LOG;     next; }
    s/^[ \t\n]+//;              # delete leading space
    s/[ \t\n]+$//;              # delete trailing space

    push (@changed_files, split) if ($state == $STATE_CHANGED);
    push (@added_files,   split) if ($state == $STATE_ADDED);
    push (@removed_files, split) if ($state == $STATE_REMOVED);
    push (@log_lines,     $_)    if ($state == $STATE_LOG);
}

I need a concenses on this, but I am willing to delete the line
that removes the leading space, it has annoyed me on several occasions.


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                   Custom computers for FreeBSD