From owner-cvs-all@FreeBSD.ORG  Tue Aug 16 21:29:56 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4A18D16A41F;
	Tue, 16 Aug 2005 21:29:56 +0000 (GMT)
	(envelope-from krion@voodoo.oberon.net)
Received: from voodoo.oberon.net (voodoo.oberon.net [212.118.165.100])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9A10D43D48;
	Tue, 16 Aug 2005 21:29:54 +0000 (GMT)
	(envelope-from krion@voodoo.oberon.net)
Received: from krion by voodoo.oberon.net with local (Exim 4.52 (FreeBSD))
	id 1E590H-000GGU-E9; Tue, 16 Aug 2005 23:29:49 +0200
Date: Tue, 16 Aug 2005 23:29:49 +0200
From: Kirill Ponomarew <krion@voodoo.oberon.net>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20050816212949.GG55949@voodoo.oberon.net>
References: <200508161859.j7GIx0jU013523@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200508161859.j7GIx0jU013523@repoman.freebsd.org>
X-NCC-Regid: de.oberon
X-NIC-HDL: KP869-RIPE
Keywords: 579279786
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/crypto/rijndael rijndael-alg-fst.c
	src/sys/opencrypto xform.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Aug 2005 21:29:56 -0000

On Tue, Aug 16, 2005 at 06:59:00PM +0000, Pawel Jakub Dawidek wrote:
> pjd         2005-08-16 18:59:00 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/crypto/rijndael  rijndael-alg-fst.c 
>     sys/opencrypto       xform.c 
>   Log:
>   Check key size for rijndael, as invalid key size can lead to kernel panic.
>   It checked other algorithms against this bug and it seems they aren't
>   affected.
>   
>   Reported by:    Mike Tancsa <mike@sentex.net>
>   PR:             i386/84860
>   Reviewed by:    phk, cperciva(x2)

I couldn't build it:

cc -O2 -fno-strict-aliasing -pipe  -I/usr/src/sbin/gbde/../../sys -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -c /usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c
/usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c: In function `rijndaelKeySetupEnc':
/usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c:737: warning: implicit declaration of function `KASSERT'
/usr/src/sbin/gbde/../../sys/crypto/rijndael/rijndael-alg-fst.c:738: warning: left-hand operand of comma expression has no effect
*** Error code 1

Stop in /usr/src/sbin/gbde.

-Kirill