From owner-freebsd-ports@FreeBSD.ORG Sat Feb 21 23:05:46 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA463106566B; Sat, 21 Feb 2009 23:05:46 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 7E1E08FC18; Sat, 21 Feb 2009 23:05:46 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from [192.168.1.2] (adsl-157-36-144.bna.bellsouth.net [70.157.36.144]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n1LN4Nia083431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 21 Feb 2009 18:04:24 -0500 (EST) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: Anonymous In-Reply-To: <86r61svw0u.fsf@gmail.com> References: <86bpsw2tbf.fsf@gmail.com> <20090221104501.06e778f1@it.buh.tecnik93.com> <86r61svw0u.fsf@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-PVflyK0rhdgJ8ajcX1Nb" Organization: FreeBSD Date: Sat, 21 Feb 2009 17:05:38 -0600 Message-Id: <1235257538.1278.9.camel@widget.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.24.4 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL, RDNS_DYNAMIC autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: Ion-Mihai Tetcu , freebsd-ports@freebsd.org Subject: Re: git snapshots, PORTVERSION, PORTEPOCH X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2009 23:05:47 -0000 --=-PVflyK0rhdgJ8ajcX1Nb Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2009-02-21 at 15:01 +0300, Anonymous wrote: > Ion-Mihai Tetcu writes: >=20 > > On Sat, 21 Feb 2009 09:32:52 +0300 > > Anonymous wrote: > > > >> Would it be okay if I use commit hash in PORTVERSION and constantly > >> bump PORTEPOCH on each update? Are there any such precedents? > >>=20 > >> %%% > >> PORTVERSION=3D 0.0.10${SNAPSUFFIX} > >> PORTEPOCH=3D 1 > >>=20 > >> SNAPSUFFIX=3D .${SNAPTYPE}.${SNAPREV} > >> SNAPTYPE=3D git > >> SNAPREV=3D e09f50e > >> %%% > >>=20 > >> Where PKGNAME would look like > >>=20 > >> myport-0.0.10.git.e09f50e,1 > >>=20 > >> I want to keep commit reference in place and refrain from using vague > >> dates in PORTVERSION because there can be several commits per day. And > >> for curious users I can include ChangeLog file in distfile generated > >> from git-log command. > > > > No, please don't do this. We use PORTEPOCH when there's no other way. >=20 > OK. I can include date before commit hash and drop use of PORTEPOCH. > It would look like >=20 > SNAPSUFFIX=3D .20090219.e09f50e >=20 > Any other objections? I don't think that it is likely that we will be able to make that many commits to the ports system. I would just use the date as SNAPSUFFIX and just record the master commit in the Changelog, or maybe in pkg-message or both. I really think that more than weekly updates is probably impractical for the ports system. Maybe twice a week, but even with a rapidly changing code base, more frequent updates won't really be useful. robert. > > > > Use, like other ports do: > > PORTVERSION=3D 0.0.10 > > PORTREVISION=3D ${SNAPDATE} > > > > I don't see what role SNAPTYPE would have. >=20 > SNAPTYPE isn't neccessary, just a little convenience. >=20 > > Since you have the date, you can easily get the git magic string. >=20 > Dates aren't atomic. That would require precise dates up to seconds and > still leave place for ambiguity. I opt to not drop git magic string if > possible else talking to upstream would be a little harder. > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" --=20 Robert Noland FreeBSD --=-PVflyK0rhdgJ8ajcX1Nb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEABECAAYFAkmgiMIACgkQM4TrQ4qfRONjXgCaAzDTMbOp4j+U5abxl3fbIyjp fF8An2ZyCPyg2iladwIWqNGvJAHoQjMI =h1w3 -----END PGP SIGNATURE----- --=-PVflyK0rhdgJ8ajcX1Nb--