From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 30 13:20:04 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 666AA106566B for ; Sun, 30 Aug 2009 13:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3B27E8FC13 for ; Sun, 30 Aug 2009 13:20:04 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7UDK4Fr073900 for ; Sun, 30 Aug 2009 13:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7UDK4Z7073899; Sun, 30 Aug 2009 13:20:04 GMT (envelope-from gnats) Date: Sun, 30 Aug 2009 13:20:04 GMT Message-Id: <200908301320.n7UDK4Z7073899@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Marc Fonvieille Cc: Subject: Re: kern/138341: [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Marc Fonvieille List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Aug 2009 13:20:04 -0000 The following reply was made to PR kern/138341; it has been noted by GNATS. From: Marc Fonvieille To: Eugene Grosbein Cc: FreeBSD-gnats-submit@FreeBSD.org, stable@freebd.org, qa@FreeBSD.org Subject: Re: kern/138341: [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module Date: Sun, 30 Aug 2009 15:16:25 +0200 On Sun, Aug 30, 2009 at 08:40:07PM +0800, Eugene Grosbein wrote: > > > > I suspect it's the problem I met when I tried to do a > > > > make -DMODULES_WITH_WORLD="YES" buildworld > > > > and many modules were concerned. See the following patch: > > > > Index: sys/modules/dtrace/lockstat/Makefile > > =================================================================== > > --- sys/modules/dtrace/lockstat/Makefile (revision 196013) > > +++ sys/modules/dtrace/lockstat/Makefile (working copy) > > @@ -5,7 +5,7 @@ > > KMOD= lockstat > > SRCS= lockstat.c > > > > -SRCS+= vnode_if.h > > +SRCS+= vnode_if.h opt_kdtrace.h > > > > CFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris \ > > -I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \ > > Index: sys/modules/sysvipc/sysvsem/Makefile > > =================================================================== > > --- sys/modules/sysvipc/sysvsem/Makefile (revision 196013) > > +++ sys/modules/sysvipc/sysvsem/Makefile (working copy) > > @@ -3,6 +3,6 @@ > > .PATH: ${.CURDIR}/../../../kern > > > > KMOD= sysvsem > > -SRCS= sysv_sem.c opt_sysvipc.h > > +SRCS= sysv_sem.c opt_sysvipc.h opt_compat.h > > > > .include > > Index: sys/modules/sysvipc/sysvmsg/Makefile > > =================================================================== > > --- sys/modules/sysvipc/sysvmsg/Makefile (revision 196013) > > +++ sys/modules/sysvipc/sysvmsg/Makefile (working copy) > > @@ -3,6 +3,6 @@ > > .PATH: ${.CURDIR}/../../../kern > > > > KMOD= sysvmsg > > -SRCS= sysv_msg.c opt_sysvipc.h > > +SRCS= sysv_msg.c opt_sysvipc.h opt_compat.h > > > > .include > > > > You are right, other modules are concerned and your patch is more complete > and correct. Vote for commit :-) > For info this unbreak things for most of archs but mips and arm which need more work in sys/modules/Makefile. However we can already commit this patch. -- Marc