From owner-p4-projects@FreeBSD.ORG Mon Jan 7 07:46:54 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3FB6E16A419; Mon, 7 Jan 2008 07:46:54 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0579D16A417 for ; Mon, 7 Jan 2008 07:46:54 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F252213C467 for ; Mon, 7 Jan 2008 07:46:53 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m077kr4V031571 for ; Mon, 7 Jan 2008 07:46:53 GMT (envelope-from jb@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m077krmi031568 for perforce@freebsd.org; Mon, 7 Jan 2008 07:46:53 GMT (envelope-from jb@freebsd.org) Date: Mon, 7 Jan 2008 07:46:53 GMT Message-Id: <200801070746.m077krmi031568@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jb@freebsd.org using -f From: John Birrell To: Perforce Change Reviews Cc: Subject: PERFORCE change 132686 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2008 07:46:54 -0000 http://perforce.freebsd.org/chv.cgi?CH=132686 Change 132686 by jb@jb_freebsd1 on 2008/01/07 07:46:37 Revise a couple of comments. I'm beginning to dislike the name 'invop' used by Sun. It applies to i386, but on amd64 it's actually a breakpoint trap, not a fault. Affected files ... .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_load.c#26 edit .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_unload.c#22 edit Differences ... ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_load.c#26 (text+ko) ==== @@ -53,7 +53,7 @@ /* Hang our hook for thread switches. */ dtrace_vtime_switch_func = dtrace_vtime_switch; - /* Hang our hook for invalid opcodes. */ + /* Hang our hook for exceptions. */ dtrace_invop_init(); /* ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_unload.c#22 (text+ko) ==== @@ -159,7 +159,7 @@ /* XXX Hack */ mutex_destroy(&mod_lock); - /* Reset out hook for invalid opcodes. */ + /* Reset our hook for exceptions. */ dtrace_invop_uninit(); /*