From owner-svn-src-head@FreeBSD.ORG Sun Feb 3 04:04:54 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 19A7C289 for ; Sun, 3 Feb 2013 04:04:54 +0000 (UTC) (envelope-from giffunip@yahoo.com) Received: from nm5-vm0.bullet.mail.bf1.yahoo.com (nm5-vm0.bullet.mail.bf1.yahoo.com [98.139.213.150]) by mx1.freebsd.org (Postfix) with SMTP id 9277D386 for ; Sun, 3 Feb 2013 04:04:53 +0000 (UTC) Received: from [98.139.212.144] by nm5.bullet.mail.bf1.yahoo.com with NNFMP; 03 Feb 2013 04:04:46 -0000 Received: from [98.139.212.204] by tm1.bullet.mail.bf1.yahoo.com with NNFMP; 03 Feb 2013 04:04:46 -0000 Received: from [127.0.0.1] by omp1013.mail.bf1.yahoo.com with NNFMP; 03 Feb 2013 04:04:46 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 505808.36970.bm@omp1013.mail.bf1.yahoo.com Received: (qmail 801 invoked by uid 60001); 3 Feb 2013 04:04:46 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1359864286; bh=m+znPX9+Zkyx1bUwVH6nXg8mnKtRaLwqpZnWtIVZzpA=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-RocketYMMF:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=VC5BuE3QbCWd+QNwSWUSPv6zlR1k2sSlFqJJM5a0eWbQ/7v9D4PGsUccfObb9yUMAxtgAXb178CFd9kyNATN9GFzll6GWxY7JZb+HY7vCmpfX6COmBMvCnkH/wjpJy6jgV0saK/eAqVS5yjHChe9bRKfarAwiZj37CdFdcy8xM0= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-RocketYMMF:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=jC0BdP6qjK16CGj3FE7A+ZRmnsK7iDVcXwqBqdRhPoz0d288JAO8Xwa4eY7enW9cBhTMHLXNYI657tlg6rOouiaA058UtD56WNngfHaKG+b3hbuLk0JZKwpXHq9oAKIAvGyFDEBYtg8fTHpB04CGLVpllYy1lKv8cb+dqHtkTsQ=; X-YMail-OSG: 4RUkJdkVM1mPRN5rVFeDa_GgTmWy2azgGuc7YTGs1i72K6. i2eR4VSeIFbo0ObpChx9vb.grVVNgGRYHNUt6Iuk_PPg_W3xbSD3Ie_9nX8E 9wax.1o3Zs4SWRopdmZQpAuMuKCadAReweOM_NK9lMG4QafUe3AwzqA3xlBp uHI8nJMvg7LowrevJc17My08ZyUpIrlS2aP4tElk3zUctGfotU5y3pizMiGF JfccPVH7LneEk9wR5jrG5tcTF7D.3bjLs3.ADznEC_ivQ3PGj3gRBy9Jr.fW 3UiWTJfH0iVOs3fbJan_jHY5SW6bI8obk.L0wN3HUUTId4twR_XGCXKy3RbQ 4db4VNHIDbWvLo1HuBnSo2G7vCpSGLag5eO5P7P36BL7FrXuFFlCPACRaPox wmDtyGDJ8vKRljQIwkfGR_oFwYwsUTyqwl0m0bMNLIgK5P1hEsa_5gqgZ5TF hemllGfWliwji8jWzcmngIa4ZZe9XI1v_3Oq5Bg0FDpK7OVT37S7c378hsm9 rC1zJ_Nmfj5v918mcyg-- Received: from [200.118.157.7] by web162102.mail.bf1.yahoo.com via HTTP; Sat, 02 Feb 2013 20:04:46 PST X-Rocket-MIMEInfo: 001.001, SGkgRWl0YW47CgoKLS0tLS0gTWVzc2FnZ2lvIG9yaWdpbmFsZSAtLS0tLQo.IERhOiBFaXRhbiBBZGxlcsKgCgo.IAo.IE9uIDIgRmVicnVhcnkgMjAxMyAyMDo1NCwgUGVkcm8gRi4gR2lmZnVuaSA8cGZnQGZyZWVic2Qub3JnPiB3cm90ZToKPj4gIEF1dGhvcjogcGZnCj4.ICBEYXRlOiBTdW4gRmViwqAgMyAwMTo1NDoyNSAyMDEzCj4.ICBOZXcgUmV2aXNpb246IDI0NjI3OAo.PiAgVVJMOiBodHRwOi8vc3Zud2ViLmZyZWVic2Qub3JnL2NoYW5nZXNldC9iYXNlLzI0NjI3OAo.PiAKPj4gIExvZzoKPj4gwqABMAEBAQE- X-RocketYMMF: giffunip X-Mailer: YahooMailWebService/0.8.131.499 References: <201302030154.r131sQZm084127@svn.freebsd.org> Message-ID: <1359864286.77306.YahooMailNeo@web162102.mail.bf1.yahoo.com> Date: Sat, 2 Feb 2013 20:04:46 -0800 (PST) From: Pedro Giffuni Subject: Re: svn commit: r246278 - head/usr.sbin/crunch/crunchide To: Eitan Adler In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Pedro Giffuni List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2013 04:04:54 -0000 Hi Eitan;=0A=0A=0A----- Messaggio originale -----=0A> Da: Eitan Adler=A0=0A= =0A> =0A> On 2 February 2013 20:54, Pedro F. Giffuni wrot= e:=0A>> Author: pfg=0A>> Date: Sun Feb=A0 3 01:54:25 2013=0A>> New Revis= ion: 246278=0A>> URL: http://svnweb.freebsd.org/changeset/base/246278=0A>>= =0A>> Log:=0A>> =A0 crunch: Sync some NetBSD changes=0A>> =0A>> =A0 Fix= a couple of free's in previous commit.=0A>> =0A>> =A0 Obtained from:=A0 = =A0 =A0 =A0 NetBSD=0A>> =A0 MFC after:=A0 =A0 1 week=0A>> =0A>> Modified:= =0A>> =A0 head/usr.sbin/crunch/crunchide/exec_elf32.c=0A>> =0A>> Modified= : head/usr.sbin/crunch/crunchide/exec_elf32.c=0A>> =0A> =3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A>> --= - head/usr.sbin/crunch/crunchide/exec_elf32.c Sun Feb=A0 3 01:22:28 2013=A0= =A0 =0A> =A0 =A0 (r246277)=0A>> +++ head/usr.sbin/crunch/crunchide/exec_e= lf32.c Sun Feb=A0 3 01:54:25 2013=A0 =A0 =0A> =A0 =A0 (r246278)=0A>> @@ -3= 84,6 +384,8 @@ out:=0A>> =A0 =A0 =A0 =A0 if (symtabp !=3D NULL)=0A>> =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 free(symtabp);=0A>> =A0 =A0 =A0 =A0 if (strta= bp !=3D NULL)=0A>> +=A0 =A0 =A0 =A0 =A0 =A0 =A0 free(strtabp);=0A>> +=A0= =A0 =A0 if (nstrtabp !=3D NULL)=0A>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fre= e(nstrtabp);=0A> =0A> Why bother checking for NULL here?=A0 7.22.2.3.2 say= s that free(NULL)=0A> results in no action.=0A>=0A=0AYou are right. I was j= ust copying the NetBSD code blindly.=0A=0AI will clean that tomorrow when I= bring the mclinker fixes.=0A=0APedro.=A0=0A