From owner-freebsd-net@freebsd.org  Sat Oct 13 15:27:18 2018
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F29D10CD80F
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Sat, 13 Oct 2018 15:27:18 +0000 (UTC) (envelope-from lev@FreeBSD.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 43C357F16B
 for <freebsd-net@freebsd.org>; Sat, 13 Oct 2018 15:27:18 +0000 (UTC)
 (envelope-from lev@FreeBSD.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 08E5B10CD80B; Sat, 13 Oct 2018 15:27:18 +0000 (UTC)
Delivered-To: net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA11810CD809
 for <net@mailman.ysv.freebsd.org>; Sat, 13 Oct 2018 15:27:17 +0000 (UTC)
 (envelope-from lev@FreeBSD.org)
Received: from onlyone.not-for.work (onlyone.not-for.work
 [IPv6:2a01:4f8:201:6350::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 901B77F168
 for <net@FreeBSD.org>; Sat, 13 Oct 2018 15:27:17 +0000 (UTC)
 (envelope-from lev@FreeBSD.org)
Received: from lion.home.serebryakov.spb.ru (unknown
 [IPv6:2001:470:923f:1:5d37:62c7:7926:ca83])
 (Authenticated sender: lev@serebryakov.spb.ru)
 by onlyone.not-for.work (Postfix) with ESMTPSA id BAD1574B;
 Sat, 13 Oct 2018 18:27:15 +0300 (MSK)
Date: Sat, 13 Oct 2018 18:27:16 +0300
From: Lev Serebryakov <lev@FreeBSD.org>
Reply-To: Lev Serebryakov <lev@FreeBSD.org>
Organization: FreeBSD
Message-ID: <1583038851.20181013182716@serebryakov.spb.ru>
To: Eugene Grosbein <eugen@grosbein.net>, net@FreeBSD.org
Subject: Re: [Bug 231659] [em][igb] 12-ALPHA8 r339259 crashes on receive under
 load
In-Reply-To: <d9f20df1-01d6-8b96-8056-6d3a69613b47@grosbein.net>
References: <bug-231659-7501@https.bugs.freebsd.org/bugzilla/> 
 <bug-231659-7501-DMGJDwYAEL@https.bugs.freebsd.org/bugzilla/>
 <d9f20df1-01d6-8b96-8056-6d3a69613b47@grosbein.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Oct 2018 15:27:18 -0000

Hello Eugene,

Saturday, October 13, 2018, 10:04:26 AM, you wrote:

>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231659
>> 
>> --- Comment #43 from Lev A. Serebryakov <lev@FreeBSD.org> ---
>> (In reply to Eric Joyner from comment #36)
>> Yess! 
>> 
>> It helps em0 to pass all my torture tests (when I comment out this
>> "optimization" twice, for lem and em). I can not test on igb now, but  belive
>> it will help too.
>> 
>> Please, commit this fix :-)
>> 

> erj@ just did it, try updating to r339338
 Are you sure? r339338 says

======
Finishes the conversion of the 40Gb Intel Ethernet drivers to iflib(9) for
FreeBSD 12.0, and fixes numerous bugs in both ixl(4) and iavf(4).
======

 It doesn't touch e1000 or ix (ixgbe) drivers. I've updated to r339345 and
all three files:

sys/dev/e1000/em_txrx.c
sys/dev/e1000/igb_txrx.c
sys/dev/ixgbe/ix_txrx.c

 contain this buggy "budget == 1" optimization.

-- 
Best regards,
 Lev                            mailto:lev@FreeBSD.org