Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 May 2011 23:35:50 +0000 (UTC)
From:      Attilio Rao <attilio@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r222234 - head/sys/mips/include
Message-ID:  <201105232335.p4NNZoMJ042544@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: attilio
Date: Mon May 23 23:35:50 2011
New Revision: 222234
URL: http://svn.freebsd.org/changeset/base/222234

Log:
  Merge r221846 from largeSMP project branch:
  Fix arguments passing to _long() version of atomic function for mips.
  
  The native implementation is bogus in that regard and offers the same
  problem solved for powerpc as r222198, but mips' guys just wanted a
  small and self-contained patch for mips rather than rewriting the
  whole support.
  
  Reviewed by:	art, imp
  Tested by:	gonzo
  MFC after:	2 weeks

Modified:
  head/sys/mips/include/atomic.h

Modified: head/sys/mips/include/atomic.h
==============================================================================
--- head/sys/mips/include/atomic.h	Mon May 23 22:31:42 2011	(r222233)
+++ head/sys/mips/include/atomic.h	Mon May 23 23:35:50 2011	(r222234)
@@ -581,32 +581,47 @@ atomic_fetchadd_64(__volatile uint64_t *
 #else /* !__mips_n64 */
 
 /* Operations on longs. */
-#define	atomic_set_long		atomic_set_32
-#define	atomic_set_acq_long	atomic_set_acq_32
-#define	atomic_set_rel_long	atomic_set_rel_32
-#define	atomic_clear_long	atomic_clear_32
-#define	atomic_clear_acq_long	atomic_clear_acq_32
-#define	atomic_clear_rel_long	atomic_clear_rel_32
-#define	atomic_add_long(p, v) \
+#define	atomic_set_long(p, v)						\
+	atomic_set_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_set_acq_long(p, v)					\
+	atomic_set_acq_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_set_rel_long(p, v)					\
+	atomic_set_rel_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_clear_long(p, v)						\
+	atomic_clear_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_clear_acq_long(p, v)					\
+	atomic_clear_acq_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_clear_rel_long(p, v)					\
+	atomic_clear_rel_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_add_long(p, v)						\
 	atomic_add_32((volatile u_int *)(p), (u_int)(v))
-#define	atomic_add_acq_long	atomic_add_acq_32
-#define	atomic_add_rel_long	atomic_add_rel_32
-#define	atomic_subtract_long(p, v) \
+#define	atomic_add_acq_long(p, v)					\
+	atomic_add_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_add_rel_long(p, v)					\
+	atomic_add_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_subtract_long(p, v)					\
 	atomic_subtract_32((volatile u_int *)(p), (u_int)(v))
-#define	atomic_subtract_acq_long	atomic_subtract_acq_32
-#define	atomic_subtract_rel_long	atomic_subtract_rel_32
-#define	atomic_cmpset_long	atomic_cmpset_32
-#define	atomic_cmpset_acq_long(p, cmpval, newval) \
-	atomic_cmpset_acq_32((volatile u_int *)(p), \
-	    (u_int)(cmpval), (u_int)(newval))
-#define	atomic_cmpset_rel_long(p, cmpval, newval) \
-	atomic_cmpset_rel_32((volatile u_int *)(p), \
-	    (u_int)(cmpval), (u_int)(newval))
-#define	atomic_load_acq_long	atomic_load_acq_32
-#define	atomic_store_rel_long	atomic_store_rel_32
-#define	atomic_fetchadd_long(p, v) \
+#define	atomic_subtract_acq_long(p, v)					\
+	atomic_subtract_acq_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_subtract_rel_long(p, v)					\
+	atomic_subtract_rel_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_cmpset_long(p, cmpval, newval)				\
+	atomic_cmpset_32((volatile u_int *)(p), (u_int)(cmpval),	\
+	    (u_int)(newval))
+#define	atomic_cmpset_acq_long(p, cmpval, newval)			\
+	atomic_cmpset_acq_32((volatile u_int *)(p), (u_int)(cmpval),	\
+	    (u_int)(newval))
+#define	atomic_cmpset_rel_long(p, cmpval, newval)			\
+	atomic_cmpset_rel_32((volatile u_int *)(p), (u_int)(cmpval),	\
+	    (u_int)(newval))
+#define	atomic_load_acq_long(p)						\
+	(u_long)atomic_load_acq_32((volatile u_int *)(p))
+#define	atomic_store_rel_long(p, v)					\
+	atomic_store_rel_32((volatile u_int *)(p), (u_int)(v))
+#define	atomic_fetchadd_long(p, v)					\
 	atomic_fetchadd_32((volatile u_int *)(p), (u_int)(v))
-#define	atomic_readandclear_long	atomic_readandclear_32
+#define	atomic_readandclear_long(p)					\
+	atomic_readandclear_32((volatile u_int *)(p))
 
 #endif /* __mips_n64 */
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105232335.p4NNZoMJ042544>