Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Oct 2016 16:24:39 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r424560 - in head: audio/codec2 emulators/i386-wine-staging emulators/open-vm-tools-nox11 emulators/wine-staging graphics/djview4-qt4 java/langspec mail/mutt mail/qpopper mail/sympa mis...
Message-ID:  <20161024162439.GB10879@FreeBSD.org>
In-Reply-To: <201610241018.u9OAIoLO063839@repo.freebsd.org>
References:  <201610241018.u9OAIoLO063839@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 24, 2016 at 10:18:50AM +0000, Mathieu Arnold wrote:
> New Revision: 424560
> URL: https://svnweb.freebsd.org/changeset/ports/424560
> 
> Log:
>   OPTIONS_SET/OPTIONS_UNSET are global variables, they cannot be used in
>   ports Makefiles.
>   
>   So, replace them with OPTIONS_SLAVE, OPTIONS_EXCLUDE, OPTIONS_DEFAULT,
>   where appropriate.
> [...]
> +++ head/mail/qpopper/Makefile	Mon Oct 24 10:18:50 2016	(r424560)
> @@ -76,12 +76,6 @@ OS_DEFS+=	-DAPOP_ONLY
>  .endif
>  .endif
>  
> -# Do not install documentation since it is in pdf format and normally
> -# not used unless user wants it.
> -.if empty(PORT_OPTIONS:MDOCUMENTATION)
> -OPTIONS_UNSET+=	DOCS
> -.endif
> -
>  # If WITH_DRAC variable present in the environment, qpopper builds
>  # with Dynamic Relay Authorization Control support.
>  .if ${PORT_OPTIONS:MDRAC}
> @@ -161,7 +155,7 @@ do-install:
>  .if ${PORT_OPTIONS:MPOPPASSD}
>  	@${INSTALL_PROGRAM} ${WRKSRC}/password/poppassd ${STAGEDIR}${PREFIX}/libexec/qpoppassd
>  .endif
> -.if ${PORT_OPTIONS:MDOCS}
> +.if ${PORT_OPTIONS:MDOCUMENTATION}

Why not simply remove DOCUMENTATION in favor of standard DOCS altogether?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161024162439.GB10879>