From owner-freebsd-cvsweb@FreeBSD.ORG  Wed Nov 17 21:03:23 2004
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 65C8716A4CE
	for <freebsd-cvsweb@freebsd.org>;
	Wed, 17 Nov 2004 21:03:23 +0000 (GMT)
Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [213.243.153.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 220E643D58
	for <freebsd-cvsweb@freebsd.org>;
	Wed, 17 Nov 2004 21:03:23 +0000 (GMT)
	(envelope-from scop@FreeBSD.org)
Received: from [62.78.134.122] (cs78134122.pp.htv.fi [62.78.134.122])
	by smtp1.pp.htv.fi (Postfix) with ESMTP id 55BBA7FD0E
	for <freebsd-cvsweb@freebsd.org>;
	Wed, 17 Nov 2004 23:03:21 +0200 (EET)
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org>
To: freebsd-cvsweb@freebsd.org
In-Reply-To: <MIEKLEPPLHOCJNAGNGPHIELJCKAA.michaels@crye-leike.com>
References: <MIEKLEPPLHOCJNAGNGPHIELJCKAA.michaels@crye-leike.com>
Content-Type: text/plain
Organization: FreeBSD
Message-Id: <1100725400.21960.17.camel@bobcat.mine.nu>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) 
Date: Wed, 17 Nov 2004 23:03:21 +0200
Content-Transfer-Encoding: 7bit
Subject: Re: Possible bug in revision link generation in human readable
	diff mode
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Nov 2004 21:03:23 -0000

On Tue, 2004-11-16 at 23:24, Michael Sims wrote:

> It looks like there may be a bug in the way CVSweb generates links to specific
> revisions when showing a human-readable, or colored diff (f=h).  This problem
> appears in the latest cvsweb Debian package (3.0.2-1 in "testing") and also in the
> latest available from the CVSweb site (3.0.4).  When viewing a colored diff between
> two revisions in "Show all branches" mode, the various links to specific revisions
> lack the question mark delimiter between the file path and the query string.  For
> example, a link such as this may be generated:
> 
> http://host/cgi-bin/cvsweb/module/file.php;rev=1.15

Right.  I was able to reproduce this by setting the default diff format
to "h" in cvsweb.conf; couldn't reproduce if it was "u".  Nevertheless,
it's a bug, and your fix is correct.  I'll commit a slightly modified
one in a jiffy, it'll be included in the next cvsweb version.  Thanks!