From owner-cvs-src@FreeBSD.ORG Sat Oct 28 07:19:33 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C19816A5C7 for ; Sat, 28 Oct 2006 07:19:33 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6560243D53 for ; Sat, 28 Oct 2006 07:19:31 +0000 (GMT) (envelope-from jfvogel@gmail.com) Received: by nz-out-0102.google.com with SMTP id o37so711763nzf for ; Sat, 28 Oct 2006 00:19:30 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=f7PBhYVJp0ABqkGJPxsaFFLoRx39K6EzXBWMc7efXAhVLGRiP9ejjjVneoZ4v68Haqj+jMrzlBuSEYVTowNh/SLK+aU15i+ovUeobGydfMNGAcD0f32U8KGNYDQ5ye8Hg2LTCamQZuyfgowzp3geBx+RTci0HAgI4y68ULZY6v0= Received: by 10.35.8.13 with SMTP id l13mr998154pyi; Sat, 28 Oct 2006 00:19:30 -0700 (PDT) Received: by 10.35.118.6 with HTTP; Sat, 28 Oct 2006 00:19:25 -0700 (PDT) Message-ID: <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com> Date: Sat, 28 Oct 2006 00:19:25 -0700 From: "Jack Vogel" To: "Hiroki Sato" In-Reply-To: <20061028.161036.78701604.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200610280137.k9S1bFq2089275@repoman.freebsd.org> <20061028.161036.78701604.hrs@allbsd.org> Cc: jfv@freebsd.org, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 07:19:33 -0000 On 10/28/06, Hiroki Sato wrote: > Jack F Vogel wrote > in <200610280137.k9S1bFq2089275@repoman.freebsd.org>: > > jf> jfv 2006-10-28 01:37:14 UTC > jf> > jf> FreeBSD src repository > jf> > jf> Modified files: (Branch: RELENG_6) > jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h > jf> if_em_osdep.h > jf> Log: > jf> Merge of Intel 6.2.9 em driver code. > jf> Approved by: re, scottl, jhb, pdeuskar > jf> > jf> Revision Changes Path > jf> 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c > jf> 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h > jf> 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c > jf> 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h > jf> 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h > > Just wanted to make sure, but is the following change in if_em.c > really intentional? This means that the new version no longer > supports 82542... > > Index: if_em.c > @@ -116,8 +117,6 @@ > { 0x8086, E1000_DEV_ID_82541GI_LF, PCI_ANY_ID, PCI_ANY_ID, 0}, > { 0x8086, E1000_DEV_ID_82541GI_MOBILE, PCI_ANY_ID, PCI_ANY_ID, 0}, > > - { 0x8086, E1000_DEV_ID_82542, PCI_ANY_ID, PCI_ANY_ID, 0}, > - > { 0x8086, E1000_DEV_ID_82543GC_FIBER, PCI_ANY_ID, PCI_ANY_ID, 0}, > { 0x8086, E1000_DEV_ID_82543GC_COPPER, PCI_ANY_ID, PCI_ANY_ID, 0}, Yes that was intentional, its an ID that the Intel source has not had for some time. When I put it back in our source a while back due to a merge our test group came to me and said these adapters dont even work with the driver, so clearly no one is using them :) I asked about dropping the ID to a set of developers and got the OK to drop it. If someone actually speaks up about having hardware that was working and now is broken I'll take it all back and we can put the ID back in, is that good enough? :) Cheers, Jack