From owner-freebsd-hackers@freebsd.org Thu Apr 14 03:20:17 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E484B0E032 for ; Thu, 14 Apr 2016 03:20:17 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by mx1.freebsd.org (Postfix) with ESMTP id AEBE71777 for ; Thu, 14 Apr 2016 03:20:15 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ppp14-2-34-252.lns21.adl2.internode.on.net (HELO midget.dons.net.au) ([14.2.34.252]) by ipmail04.adl6.internode.on.net with ESMTP; 14 Apr 2016 12:50:14 +0930 Received: from [10.0.2.26] ([10.0.2.26]) (authenticated bits=0) by midget.dons.net.au (8.15.1/8.14.9) with ESMTPSA id u3E3K7iO025083 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Apr 2016 12:50:12 +0930 (CST) (envelope-from darius@dons.net.au) Subject: Re: Improving commit logs Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "O'Connor, Daniel" In-Reply-To: Date: Thu, 14 Apr 2016 12:50:07 +0930 Cc: FreeBSD Hackers Content-Transfer-Encoding: quoted-printable Message-Id: References: <56FF6534-276E-4E52-871F-5567BD9D6EC7@dons.net.au> To: Ngie Cooper X-Mailer: Apple Mail (2.3124) X-Spam-Score: -2.899 () ALL_TRUSTED,BAYES_00,URIBL_BLOCKED X-Scanned-By: MIMEDefang 2.75 on 10.0.2.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2016 03:20:17 -0000 > On 14 Apr 2016, at 12:28, Ngie Cooper wrote: >> Does anyone have any (constructive) comments or feedback? >=20 > Isn't this just an extension of what others have written up before? > Googling "writing good commit messages yielded: >=20 > 1. http://chris.beams.io/posts/git-commit/ > 2. = https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message >=20 > This is what I generally try to follow with commits... Sure, but I think it carries more weight if you can point to a specific = FreeBSD document and say "do it like this". -- Daniel O'Connor "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C