From owner-cvs-all@FreeBSD.ORG Mon Apr 2 02:39:34 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EFE9E16A402 for ; Mon, 2 Apr 2007 02:39:33 +0000 (UTC) (envelope-from zombyfork@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by mx1.freebsd.org (Postfix) with ESMTP id 8176E13C448 for ; Mon, 2 Apr 2007 02:39:33 +0000 (UTC) (envelope-from zombyfork@gmail.com) Received: by ug-out-1314.google.com with SMTP id 71so1493754ugh for ; Sun, 01 Apr 2007 19:39:32 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=LLv0Pkt6yFZBr4hSoPOKqvw4lTu4/qTaPR3wBd8rIdd5UDaJ088tNArX0ajaM09CWJJXOV+jMb0FKdTbkD3C7gR6/XsNRfaN2L+4K5PbRel+QkOJMY6AMaKUUJntuKW3bDFh30OOn+g8RmtP3pZK1isjgMR+ofPyoIibBqkeyTs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=GZVly6ORZsLQAasaXSuGOcj66zM/wyVPaiWWPUJo968U3r1SBcQi5sRYoaUL3MSqMzsKdCRROq24L5IaZRcPOLboDqo/kAWoXkZAxqrFc1c3w4zjYMHhHOBAMtJst3bgWa8p1AFtnN9TtGgnKQpcKjRCG8B8OZpPxCpsY2KAeBE= Received: by 10.114.185.8 with SMTP id i8mr1660196waf.1175480091301; Sun, 01 Apr 2007 19:14:51 -0700 (PDT) Received: by 10.115.15.4 with HTTP; Sun, 1 Apr 2007 19:14:51 -0700 (PDT) Message-ID: <346a80220704011914h4bcf13e4wfffc21ec52c4d38@mail.gmail.com> Date: Sun, 1 Apr 2007 20:14:51 -0600 From: "Coleman Kane" To: "=?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?=" In-Reply-To: <86slbkxsvm.fsf@dwp.des.no> MIME-Version: 1.0 References: <20070401070403.16724517E2@repoman.freebsd.org> <20070401091501.GK18105@deviant.kiev.zoral.com.ua> <460F8299.20307@freebsd.org> <86slbkxsvm.fsf@dwp.des.no> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Colin Percival , Kostik Belousov Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: cokane@cokane.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2007 02:39:34 -0000 On 4/1/07, Dag-Erling Sm=F8rgrav wrote: > > Colin Percival writes: > > Judging by what I see at http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/= , > > it looks like everything has been reverted now, so hopefully Kris can g= o > > ahead and redo his original commit later today without any of the > changes > > which slipped in by mistake. > > Great! I have a megapatch lined up as well. In the spirit of > sustainable kernel development, atomic operations are being renamed to > renewable operations. > > DES > -- > Dag-Erling Sm=F8rgrav - des@des.no > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > I think that I may just have to start a thread to protest your renewable operations patch. The naming conventions used in the new macros unnecessarily stick out under review of the source code where they are implemented, thus overshadowing and blocking out my abilities to inspect less prominent features in the code where they are used. I think that these aesthetic concerns in this situation override any possible gains through reduction in operation waste, and the changes should be reconsidered under these grounds. In addition, I (and others) fear that these renewable operations will render the development of devel/liboil obsolete, and its developers unemployed. -- Coleman Kane