From owner-freebsd-current@freebsd.org Sun Jan 17 16:42:06 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19F974EF885 for ; Sun, 17 Jan 2021 16:42:06 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from gmailer.gwdg.de (gmailer.gwdg.de [134.76.11.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DJggL0HYbz3R5m for ; Sun, 17 Jan 2021 16:42:05 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from excmbx-03.um.gwdg.de ([134.76.9.218] helo=email.gwdg.de) by mailer.gwdg.de with esmtp (GWDG Mailer) (envelope-from ) id 1l1B7r-0005bg-RQ; Sun, 17 Jan 2021 17:42:03 +0100 Received: from krabat.raven.hur (10.250.9.200) by EXCMBX-03.um.gwdg.de (134.76.9.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2044.4; Sun, 17 Jan 2021 17:42:03 +0100 Subject: Re: Waiting for bufdaemon To: Konstantin Belousov CC: freebsd-current References: <7c4da243-52ff-c5ee-3d56-1ae651286e0e@alvermark.net> <369b3d82-98c5-b31e-6168-4003a042f174@FreeBSD.org> <556d40b8-92d7-303e-7d87-ea496d0ca733@FreeBSD.org> <9ae3cc65-193a-39c3-4067-0d42e9f634b0@gwdg.de> Reply-To: From: Rainer Hurling Message-ID: <0699bacf-f0ae-8766-0a3d-ee292fe5c06d@gwdg.de> Date: Sun, 17 Jan 2021 17:41:58 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.250.9.200] X-ClientProxiedBy: excmbx-11.um.gwdg.de (134.76.9.220) To EXCMBX-03.um.gwdg.de (134.76.9.218) X-Virus-Scanned: (clean) by clamav X-Rspamd-Queue-Id: 4DJggL0HYbz3R5m X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2021 16:42:06 -0000 Am 17.01.21 um 10:49 schrieb Konstantin Belousov: > On Sun, Jan 17, 2021 at 10:37:18AM +0100, Rainer Hurling wrote: >> Am 17.01.21 um 05:33 schrieb Konstantin Belousov: >>> On Sat, Jan 16, 2021 at 07:41:01PM +0100, Rainer Hurling wrote: >>>> During another shutdown after heavy usage of the box, the following >>>> messages were also seen: >>>> >>>> >>>> [...] >>>> Syncing disks, vnodes remaining... 22 EFI rt_settime call faulted, error 14 >>>> efirtc0: CLOCK_SETTIME error 14 >>> >>> This means that BIOS code faulted during RTC settime call. I doubt that >>> it is related. >>> >>> On the other hand, it is good that the onfault EFI RT code got tested finally. >>> >> >> Thanks for clarification :) >> >> >> Any chance of getting a fix for the AMD CPUs in the foreseeable future? >> >> Or should I revert commit 9e680e4005b7 on affected boxes until further >> notice (as a workaround)? > > I am working on it, no ETA. > > Interesting point would be to check on machines of other testers, > if the following hides the problem. > > diff --git a/sys/x86/x86/tsc.c b/sys/x86/x86/tsc.c > index 85924df98312..5700a8ca98e5 100644 > --- a/sys/x86/x86/tsc.c > +++ b/sys/x86/x86/tsc.c > @@ -639,7 +639,7 @@ init_TSC_tc(void) > * on Intel, and MFENCE;RDTSC on AMD. > * - For really old CPUs, just use RDTSC. > */ > - if ((cpu_vendor_id == CPU_VENDOR_AMD || > + if (false && (cpu_vendor_id == CPU_VENDOR_AMD || > cpu_vendor_id == CPU_VENDOR_HYGON) && > CPUID_TO_FAMILY(cpu_id) >= 0x17) { > tsc_timecounter.tc_get_timecount = shift > 0 ? > I tried the above patch on a Ryzen 3950X. After reboot (again with long waiting for bufdaemon and more) the box had some heavy load with several jobs (llvm on Poudriere, building qt5-webengine, libreoffice and some more in parallel). All went fine. Afterwards I rebooted again. This time, the shutdown was fast without any unusual delays :) Many thanks!