From owner-cvs-all  Mon Feb 17  9:44:28 2003
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 904)
	id 5BE5537B401; Mon, 17 Feb 2003 09:44:26 -0800 (PST)
Date: Mon, 17 Feb 2003 09:44:26 -0800
From: Max Khon <fjoe@FreeBSD.org>
To: Alfred Perlstein <alfred@FreeBSD.org>
Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern sysv_shm.c
Message-ID: <20030217094426.A92612@FreeBSD.org>
References: <200302160608.h1G68t9U083470@repoman.freebsd.org> <20030216025032.A55015@FreeBSD.org> <20030216161224.GE93252@elvis.mu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20030216161224.GE93252@elvis.mu.org>; from alfred@FreeBSD.org on Sun, Feb 16, 2003 at 08:12:24AM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

hi, there!

On Sun, Feb 16, 2003 at 08:12:24AM -0800, Alfred Perlstein wrote:

> > > alfred      2003/02/15 22:08:55 PST
> > > 
> > >   Modified files:
> > >     sys/kern             sysv_shm.c 
> > >   Log:
> > >   prevent overflow in shminfo.shmmax
> > >   
> > >   Revision  Changes    Path
> > >   1.79      +5 -1      src/sys/kern/sysv_shm.c
> > > http://cvsweb.FreeBSD.org/src/sys/kern/sysv_shm.c.diff?r1=1.78&r2=1.79
> > 
> > for() loop will never be executed
> > calculations in for() loop also look suspicious
> 
> GAh, thanks!

I still can't get what you tried to do in for() loop body.
Did you want multiplication by i instead of PAGE_SIZE?

/fjoe

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message