From owner-svn-src-user@FreeBSD.ORG  Sun Sep 14 19:10:09 2014
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5EEE7CDF;
 Sun, 14 Sep 2014 19:10:09 +0000 (UTC)
Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com
 [IPv6:2607:f8b0:400e:c03::230])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 27712ABA;
 Sun, 14 Sep 2014 19:10:09 +0000 (UTC)
Received: by mail-pa0-f48.google.com with SMTP id hz1so4903211pad.21
 for <multiple recipients>; Sun, 14 Sep 2014 12:10:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=references:mime-version:in-reply-to:content-type
 :content-transfer-encoding:message-id:cc:from:subject:date:to;
 bh=9bzKWSV8W+WipK4a1Z3d0odenEQR3+BXRatiaVaJ0nI=;
 b=qtdde+jtJKzdMD0imSPdrfpdknSjaj5iWY5ztyDupH2frlR/MMnhLbYFEgPheMq9Ze
 NMPUW8oOvSydQ6NTphA/aCe4qxjm/kehAT8NsvG3zh3DdSdDnHO07sKqQ9RllsY1f31X
 cgVt27aK2TcjKccjDBll5T3yStlf+qaBz7mxhfBl3pj608eJ4vSKtbwQcooXbZQ5PKD4
 RBypSnicoU1A+JN+yBpMvFgzPyFfZ/Hw10wjVd7LpnA8eoiE3zg9YZ8QL0imIDMR3SN+
 0ivVhhqhUlvB7ElR9isRcW0LVbY0EoY2vL3wFUdASMiJOwWCvQMSDUKov8AnHjPHi1Wi
 6yJQ==
X-Received: by 10.68.252.168 with SMTP id zt8mr33170155pbc.14.1410721808704;
 Sun, 14 Sep 2014 12:10:08 -0700 (PDT)
Received: from [192.168.20.11] (c-98-247-240-204.hsd1.wa.comcast.net.
 [98.247.240.204])
 by mx.google.com with ESMTPSA id pp2sm9361420pbc.66.2014.09.14.12.10.07
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Sun, 14 Sep 2014 12:10:07 -0700 (PDT)
References: <201409140909.s8E99ncV087445@svn.freebsd.org>
 <20140914200428.P1559@besplex.bde.org>
Mime-Version: 1.0 (1.0)
In-Reply-To: <20140914200428.P1559@besplex.bde.org>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-Id: <916E2311-C6BF-423E-A149-3F1853584020@gmail.com>
X-Mailer: iPhone Mail (11D257)
From: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: svn commit: r271574 - user/ngie/add-pjdfstest/contrib/pjdfstest
Date: Sun, 14 Sep 2014 12:10:06 -0700
To: Bruce Evans <brde@optusnet.com.au>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 Garrett Cooper <ngie@freebsd.org>,
 "svn-src-user@freebsd.org" <svn-src-user@freebsd.org>
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user/>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Sep 2014 19:10:09 -0000


> On Sep 14, 2014, at 4:21, Bruce Evans <brde@optusnet.com.au> wrote:
>=20
>> On Sun, 14 Sep 2014, Garrett Cooper wrote:
>>=20
>> Log:
>> Redo r271374 by using the right typecast for comparing i and ngroups
>=20
> It is still quite broken (more broken than without the cast, since the
> cast breaks the warning).

Hi Bruce,
    I completely agree with your concerns. Since this is "contrib" code I wa=
nted to make the smallest set of changes to make things compile, then push f=
or the proper fix upstream.
    As an aside, is u_int completely portable; I personally prefer the longe=
r forms of non-fixed width types, e.g. unsigned int, but that's my personal p=
reference.
Thank you!
-Garrett=