From owner-freebsd-current@FreeBSD.ORG Sat Feb 7 09:14:01 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B1FA16A4CE for ; Sat, 7 Feb 2004 09:14:01 -0800 (PST) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7693043D2F for ; Sat, 7 Feb 2004 09:14:00 -0800 (PST) (envelope-from l.ertl@univie.ac.at) Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11]) i17HDrTX1377896; Sat, 7 Feb 2004 18:13:55 +0100 Date: Sat, 7 Feb 2004 18:13:47 +0100 (CET) From: Lukas Ertl To: Poul-Henning Kamp In-Reply-To: <40812.1075978752@critter.freebsd.dk> Message-ID: <20040207181030.H619@korben.in.tern> References: <40812.1075978752@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: imap 4243; Body=0 Fuz1=0 Fuz2=0 cc: current@freebsd.org Subject: Re: HEADSUP: disk_*(9) API change mega-patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2004 17:14:01 -0000 On Thu, 5 Feb 2004, Poul-Henning Kamp wrote: > In message <20040205114149.I618@korben.in.tern>, Lukas Ertl writes: > >On Thu, 5 Feb 2004, Poul-Henning Kamp wrote: > > > >> This is a mostly mechanical and largely untested patch, so please test > >> carefully if you have the necessary hardware. > >> > >> Kernel patch: > >> http://phk.freebsd.dk/patch/disk.patch > >> [...] > >> This patch changes the disk_*(9) API so that ownership of the "struct > >> disk" is moved from the device drivers to GEOM. This removes a lot > >> of trouble from the disk_destroy(9) handling, which should be robust > >> with this patch. > > > >Will this be a solution for the deadlock we were discussing lately on > >geom@? > > I belive so, reports confirming or denying this are most welcome. OK, I now had time to actually try the patch, and removing disks now works correctly, no deadlock anymore. One thing I noticed, though, is that even after removal of the drive there's still a /dev/da1 and /dev/da1s1 entry. lg, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/