Date: Mon, 14 Jun 2004 20:28:32 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/67937: [PATCH] www/apache13-modssl, www/apache13-modssl+ipv6: sanitize version number handling Message-ID: <A3CC02C2-BE30-11D8-9250-00039312D914@fillmore-labs.com> In-Reply-To: <200406141340.i5EDeNTV093157@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dirk Meyer wrote:
> 1. Please give an example where pkg_version does not handle the
> version check.
> I use pkg_version, and otehr tiolls without any problems.
Install the port with APACHE_WITH_MODDEFLATE=yes (sigh).
Try
pkg_version -v | grep apache
You'll get
apache+mod_ssl+mod_deflate-1.3.31+ > succeeds port (port has
1.3.31+2.8.18_4)
(not the truncated package name on -STABLE)
bump the PORTREVISION (security fix!)
pkg_version -v | grep apache
apache+mod_ssl+mod_deflate-1.3.31+ > succeeds port (port has
1.3.31+2.8.18_5)
Try
portupgrade -n 'apache*'
** No need to upgrade
'apache+mod_ssl+mod_deflate-1.3.31+2.8.18+1.0.21_4' (>=
apache+mod_ssl-1.3.31+2.8.18_5). (specify -f to force)
You'll miss security fixes! Now, is the port broken?
> 2. I can't reproduce that the port conficts with it self.
> # make -V CONFLICTS
> apache+ipv6-1.* apache+ssl-1.* apache-1.* apache-2.* apache_fp-1.*
> caudium-devel-1.* caudium10-1.* caudium12-* ru-apache+mod_ssl-1.*
> ru-apache-1.* thttpd-2.* w3c-httpd-3.* apache+mod_snmp*-1.*
> apache+mod_accel*-1.* apache+mod_deflate*-1.*
Try
make APACHE_WITH_MODDEFLATE=yes -VCONFLICTS
You'll get `apache+mod_ssl-1.*', which is *this* port, please read how
CONFLICTS work. Besides, you make it
unnecessary hard to CONFLICT with *this* port.
> 3. tunable variables are syncronized with other apache ports.
With which apache ports?
grep -l APACHE_WITH_ /usr/ports/*/apache*/Makefile
> 4. Suggested patch is a regression, it fails to build with customized
> slave ports.
What are `customized slave ports'? Of course they build.
> 5. Why do you drop support of Makefile.local?
Only bsd.port.mk includes ${MASTERDIR}/Makefile.local. Slave ports never
include
a Makefile.local in the slaves port directory. If you want to change
this, please submit
a patch for bsd.port.mk.
-Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A3CC02C2-BE30-11D8-9250-00039312D914>