From owner-freebsd-net@FreeBSD.ORG  Tue Jul  1 09:14:01 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAA3E1065671;
	Tue,  1 Jul 2008 09:14:00 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 120438FC23;
	Tue,  1 Jul 2008 09:13:59 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from localhost (amavis.str.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 6C72141C7B1;
	Tue,  1 Jul 2008 10:55:05 +0200 (CEST)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([62.111.66.27])
	by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id W0-Pz+bA67jl; Tue,  1 Jul 2008 10:55:05 +0200 (CEST)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id 174EB41C7B0; Tue,  1 Jul 2008 10:55:05 +0200 (CEST)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 3C7EF44487F;
	Tue,  1 Jul 2008 08:51:30 +0000 (UTC)
Date: Tue, 1 Jul 2008 08:51:28 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: Andre Oppermann <andre@freebsd.org>
In-Reply-To: <4869EC1E.8060009@freebsd.org>
Message-ID: <20080701084933.W57089@maildrop.int.zabbadoz.net>
References: <4852E23E.2040505@gtcomm.net> <4854EBF1.7020708@FreeBSD.org>
	<l68b649csbvpf6l1ud32atuhq80rr3gsvj@4ax.com>
	<200807010606.m6166jFe084204@lava.sentex.ca>
	<4869EC1E.8060009@freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-net@freebsd.org, Paul <paul@gtcomm.net>,
	"Bruce M. Simpson" <bms@freebsd.org>, Mike Tancsa <mike@sentex.net>
Subject: Re: Route messages
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jul 2008 09:14:01 -0000

On Tue, 1 Jul 2008, Andre Oppermann wrote:

Hi,

> Mike Tancsa wrote:
>> I am thinking
>> 
>> http://lists.freebsd.org/pipermail/cvs-src/2008-April/090303.html
>> is the commit ? If I revert to the prev version, the issue goes away.

Ha, I finally know why I ended up on Cc: of a thread I had no idea
about. Someone could have told me instead of blindly adding me;-)


> Yes, this change doesn't look right.  It should only do the route
> lookup in ip_input.c when there was an EMSGSIZE error returned by
> ip_output().  The rtalloc_ign() call causes the message to be sent
> because it always sets report to one.  The default message is RTM_MISS.
>
> I'll try to prep an updated patch which doesn't have these issues later
> today.

Yeah my bad. Sorry.

If you do that, do not do an extra route lookup if possible, correct
the rtalloc call. Thanks.


Bjoern

-- 
Bjoern A. Zeeb              Stop bit received. Insert coin for new game.