From owner-freebsd-current Wed Mar 20 10: 5:33 2002 Delivered-To: freebsd-current@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 9211837B400 for ; Wed, 20 Mar 2002 10:05:28 -0800 (PST) Received: (qmail 2494 invoked from network); 20 Mar 2002 18:05:28 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 20 Mar 2002 18:05:28 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g2KI5xv62829; Wed, 20 Mar 2002 13:05:59 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020320172647.A64459@bofh.enst.fr> Date: Wed, 20 Mar 2002 13:05:31 -0500 (EST) From: John Baldwin To: Pierre Beyssac Subject: RE: i386/boot2.c patches Cc: freebsd-current@freebsd.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 20-Mar-2002 Pierre Beyssac wrote: > Would anyone mind if I commit the following to i386/boot2.c? > I've reviewed and tested them. > > add -n option to boot2 to disallow user interruption > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36016 Looks fine to me. > boot2 cleanup (modulo style(9) and a minor typo in a comment): > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36015 Looks mostly ok to me. Not entirely sure about the autoboot changes as it looks weird to load(kname) right before you change what kname is. I think the logic must somehow be wrong there. Might want to ask Robert Nordier for review. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message