From nobody Wed Jan 25 16:35:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P28Zl4bvTz3bsGY; Wed, 25 Jan 2023 16:35:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P28Zl3tXTz4Ps5; Wed, 25 Jan 2023 16:35:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674664511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NkJqln0wZ0VXEvGSc0e8B4OezPfZb43b3nHODnab4TI=; b=hUWVYscINBVNhyIbhAN0qy3ZrASnEhj02vSBDZP7qdTjYkRh0/BNCUnaQY3Zyk+8HcQbRE S09awTiisG8+uQH6t8b8nw9eq814n+3TatDb3aBoPOtzThsT6T910QApOJQLBqHutH4Zar wATAODs1PmsJ2BL/sEu+vXWe4XtZIrxeL3MaczTpg+oJHXR2Y49U7IOAoI4rTCtWSyJPmS zaShwHBqzSmBDeCOOfEH+p0or3ZJO/v6/HKHWbLnq3FaoJxngICPOUyXZ2X4xhyqqlVZjp aSNoYSH15VSika3I7VZMPgL7iQ/XhngxevOX4mLksunwvXNkjpWYgAcOyEAAWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674664511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NkJqln0wZ0VXEvGSc0e8B4OezPfZb43b3nHODnab4TI=; b=XH+kpH2Xm4kzVclL2M7nmjmxKvkrsY+Xu/B3OEdQMCrEsFJ6iTHf49iFUaanVn4wIHQbHr fDEJ/il9cAcMQfwGBXLFeCwZI4Y+hewSVdBlYbcYQao2lb5ysSs+cbmS+qorTEZJ1UEmkE oSfh9mFEJ/0WbdmOagyi1fiO9qy0rZP/I+LrIBeEP2YZKVczk0XB/bcqKNofG65N+cUZfi zpdbrqQFKmJIKaBzR+a5SR0+i4iY5Vip0n9PyIJ7T7hbcEpB6/AQv3lKeVhBCmQwQSqmKD 70hcNxRGFegf6YsPYffyUQNJ+XEkwi+VF2D4jg+AKM8LUm/IGp6aC2BLmptcLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674664511; a=rsa-sha256; cv=none; b=pcDgiRy5Ht0L1zfWtTtUYO5kjYz5RlhuvY4dAFSYp3ekUD7Jyw/5p07ypA5cR6vSv/OdHR dZkz334hc6lreU0ef7tEzgF+Wz2sbCTySZwQh+IdTHc5/HrRPtG9uf67VI4/Y03AxEdQzj QT4A6p6oYsHbrgztEmN7p3/ScxmVKJii465FhHBrJNffyDSw3shkKXNGQu40XfPN2rSWwB 8iGh6dRefnl8KOGTiAy1eaTAlfrr9ef/nc8LBTdplH7bIJM9H7MmOQzNtyLS4OxIqrZPsf mbvG1PfZ9A3Fj7je3XgNr/2XD7B0fVjCznBBIQNHkuOEG4RX3k+3W+FggUKhEQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P28Zl2qVyzvns; Wed, 25 Jan 2023 16:35:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30PGZBiC073719; Wed, 25 Jan 2023 16:35:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30PGZBSB073718; Wed, 25 Jan 2023 16:35:11 GMT (envelope-from git) Date: Wed, 25 Jan 2023 16:35:11 GMT Message-Id: <202301251635.30PGZBSB073718@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Alexander V. Chernikov" Subject: git: 20ea7f26e413 - main - pytest: delete interfaces from inside the jail. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: melifaro X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 20ea7f26e41375828a390fba613b86acfe366add Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by melifaro: URL: https://cgit.FreeBSD.org/src/commit/?id=20ea7f26e41375828a390fba613b86acfe366add commit 20ea7f26e41375828a390fba613b86acfe366add Author: Alexander V. Chernikov AuthorDate: 2023-01-25 16:32:52 +0000 Commit: Alexander V. Chernikov CommitDate: 2023-01-25 16:34:17 +0000 pytest: delete interfaces from inside the jail. This change follows the approach used in 80fc25025ffc, to minimise the impact of the delayed interface migration. MFC after: 2 weeks --- tests/atf_python/sys/net/vnet.py | 46 ++++++++++++++++++++++++++++++++-------- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/tests/atf_python/sys/net/vnet.py b/tests/atf_python/sys/net/vnet.py index 1a8efe0d9edc..1f61269ffe6c 100644 --- a/tests/atf_python/sys/net/vnet.py +++ b/tests/atf_python/sys/net/vnet.py @@ -1,6 +1,7 @@ #!/usr/local/bin/python3 import copy import ipaddress +import re import os import socket import sys @@ -150,6 +151,7 @@ class VnetInterface(object): class IfaceFactory(object): INTERFACES_FNAME = "created_ifaces.lst" + AUTODELETE_TYPES = ("epair", "lo", "tap", "tun") def __init__(self): self.file_name = self.INTERFACES_FNAME @@ -158,19 +160,46 @@ class IfaceFactory(object): with open(self.file_name, "a") as f: f.write(iface_name + "\n") + def _list_ifaces(self) -> List[str]: + ret: List[str] = [] + try: + with open(self.file_name, "r") as f: + for line in f: + ret.append(line.strip()) + except OSError: + pass + return ret + def create_iface(self, alias_name: str, iface_name: str) -> List[VnetInterface]: ifaces = VnetInterface.create_iface(alias_name, iface_name) for iface in ifaces: - self._register_iface(iface.name) + if not self.is_autodeleted(iface.name): + self._register_iface(iface.name) return ifaces + @staticmethod + def is_autodeleted(iface_name: str) -> bool: + iface_type = re.split(r"\d+", iface_name)[0] + return iface_type in IfaceFactory.AUTODELETE_TYPES + + def cleanup_vnet_interfaces(self, vnet_name: str) -> List[str]: + """Destroys""" + ifaces_lst = ToolsHelper.get_output( + "/usr/sbin/jexec {} ifconfig -l".format(vnet_name) + ) + for iface_name in ifaces_lst.split(): + if not self.is_autodeleted(iface_name): + if iface_name not in self._list_ifaces(): + print("Skipping interface {}:{}".format(vnet_name, iface_name)) + continue + run_cmd( + "/usr/sbin/jexec {} ifconfig {} destroy".format(vnet_name, iface_name) + ) + def cleanup(self): try: - with open(self.file_name, "r") as f: - for line in f: - run_cmd("/sbin/ifconfig {} destroy".format(line.strip())) os.unlink(self.INTERFACES_FNAME) - except Exception: + except OSError: pass @@ -260,7 +289,7 @@ class VnetFactory(object): try: jid_str = run_cmd(cmd) jid = int(jid_str) - except ValueError as e: + except ValueError: print("Jail creation failed, output: {}".format(jid_str)) raise self._register_vnet(vnet_name) @@ -276,13 +305,12 @@ class VnetFactory(object): return VnetInstance(vnet_alias, vnet_name, jid, ifaces) def cleanup(self): + iface_factory = IfaceFactory() try: with open(self.file_name) as f: for line in f: vnet_name = line.strip() - ToolsHelper.print_output( - "/usr/sbin/jexec {} ifconfig -l".format(vnet_name) - ) + iface_factory.cleanup_vnet_interfaces(vnet_name) run_cmd("/usr/sbin/jail -r {}".format(vnet_name)) os.unlink(self.JAILS_FNAME) except OSError: