From owner-freebsd-current Mon Dec 11 15:50: 6 2000 From owner-freebsd-current@FreeBSD.ORG Mon Dec 11 15:50:05 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mass.osd.bsdi.com (adsl-63-202-176-64.dsl.snfc21.pacbell.net [63.202.176.64]) by hub.freebsd.org (Postfix) with ESMTP id 0002F37B400; Mon, 11 Dec 2000 15:50:04 -0800 (PST) Received: from mass.osd.bsdi.com (localhost [127.0.0.1]) by mass.osd.bsdi.com (8.11.1/8.11.1) with ESMTP id eBBNxs301035; Mon, 11 Dec 2000 15:59:54 -0800 (PST) (envelope-from msmith@mass.osd.bsdi.com) Message-Id: <200012112359.eBBNxs301035@mass.osd.bsdi.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Stefan Esser Cc: freebsd-current@freebsd.org Subject: Re: PCI power states (was Re: fxp driver not reset after Windows reboot? ) In-reply-to: Your message of "Mon, 11 Dec 2000 22:51:27 +0100." <20001211225127.B73017@StefanEsser.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 11 Dec 2000 15:59:54 -0800 From: Mike Smith Sender: msmith@mass.osd.bsdi.com Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > pci_enable_busmaster(dev); > > pci_enable_io(dev, SYS_RES_IOPORT | SYS_RES_MEMORY); > > pci_set_powerstate(dev, PCI_POWERSTATE_D0); > > > > Consider the above a request for review on the matter. > > Shouldn't that be: > > pci_enable_io(dev, SYS_RES_IOPORT | SYS_RES_MEMORY); > pci_set_powerstate(dev, PCI_POWERSTATE_D0); > device_specific_init(dev); > pci_enable_busmaster(dev); In terms of ordering? Yes, definitely,and thanks for pointing it out. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message