From owner-p4-projects@FreeBSD.ORG  Tue Jun 15 23:14:08 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 59AA61065674; Tue, 15 Jun 2010 23:14:08 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1AD241065679
	for <perforce@freebsd.org>; Tue, 15 Jun 2010 23:14:08 +0000 (UTC)
	(envelope-from gabor@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 0886F8FC1B
	for <perforce@freebsd.org>; Tue, 15 Jun 2010 23:14:08 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o5FNE7IH093617
	for <perforce@freebsd.org>; Tue, 15 Jun 2010 23:14:07 GMT
	(envelope-from gabor@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o5FNE7nY093615
	for perforce@freebsd.org; Tue, 15 Jun 2010 23:14:07 GMT
	(envelope-from gabor@freebsd.org)
Date: Tue, 15 Jun 2010 23:14:07 GMT
Message-Id: <201006152314.o5FNE7nY093615@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gabor@freebsd.org using -f
From: Gabor Kovesdan <gabor@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 179665 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jun 2010 23:14:08 -0000

http://p4web.freebsd.org/@@179665?ac=10

Change 179665 by gabor@gabor_aspire on 2010/06/15 23:14:02

	- Fix some warnings
	
	Found by: clang

Affected files ...

.. //depot/projects/soc2008/gabor_textproc/grep/file.c#50 edit
.. //depot/projects/soc2008/gabor_textproc/grep/grep.c#94 edit

Differences ...

==== //depot/projects/soc2008/gabor_textproc/grep/file.c#50 (text+ko) ====

@@ -81,7 +81,7 @@
 		if (bzerr == BZ_STREAM_END)
 			return (-1);
 		else if (bzerr != BZ_SEQUENCE_ERROR && bzerr != BZ_OK)
-			errx(2, getstr(2));
+			errx(2, "%s", getstr(2));
 		return (c);
 	}
 	return (-1);
@@ -180,7 +180,7 @@
 {
 	struct file *f;
 
-	snprintf(fname, sizeof fname, getstr(1));
+	snprintf(fname, sizeof fname, "%s", getstr(1));
 
 	f = grep_malloc(sizeof *f);
 

==== //depot/projects/soc2008/gabor_textproc/grep/grep.c#94 (text+ko) ====

@@ -149,10 +149,10 @@
 usage(void)
 {
 	fprintf(stderr, getstr(4), __progname);
-	fprintf(stderr, getstr(5));
-	fprintf(stderr, getstr(5));
-	fprintf(stderr, getstr(6));
-	fprintf(stderr, getstr(7));
+	fprintf(stderr, "%s", getstr(5));
+	fprintf(stderr, "%s", getstr(5));
+	fprintf(stderr, "%s", getstr(6));
+	fprintf(stderr, "%s", getstr(7));
 	exit(2);
 }
 
@@ -530,7 +530,7 @@
 			else if (strcmp("text", optarg) == 0)
 				binbehave = BINFILE_TEXT;
 			else
-				errx(2, getstr(8));
+				errx(2, "%s", getstr(8));
 			break;
 		case COLOR_OPT:
 			if (optarg == NULL || strcmp("auto", optarg) == 0 || strcmp("always", optarg) == 0 ) {
@@ -542,7 +542,7 @@
 			} else if (strcmp("never", optarg) == 0)
 				color = NULL;
 			else
-				errx(2, getstr(3));
+				errx(2, "%s", getstr(3));
 			break;
 		case LABEL_OPT:
 			label = optarg;