From owner-svn-src-all@FreeBSD.ORG Tue Feb 3 16:45:23 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 472281065672; Tue, 3 Feb 2009 16:45:23 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245]) by mx1.freebsd.org (Postfix) with ESMTP id B074A8FC0A; Tue, 3 Feb 2009 16:45:22 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from mail-gw7.york.ac.uk (mail-gw7.york.ac.uk [144.32.129.30]) by mail-gw0.york.ac.uk (8.13.6/8.13.6) with ESMTP id n13GjGof029126; Tue, 3 Feb 2009 16:45:16 GMT Received: from buffy-128.york.ac.uk ([144.32.128.160] helo=buffy.york.ac.uk) by mail-gw7.york.ac.uk with esmtps (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1LUOOh-0003GR-VB; Tue, 03 Feb 2009 16:45:15 +0000 Received: from buffy.york.ac.uk (localhost [127.0.0.1]) by buffy.york.ac.uk (8.14.2/8.14.2) with ESMTP id n13GjFl6079343; Tue, 3 Feb 2009 16:45:15 GMT (envelope-from gavin@FreeBSD.org) Received: (from ga9@localhost) by buffy.york.ac.uk (8.14.2/8.14.2/Submit) id n13GjFbZ079342; Tue, 3 Feb 2009 16:45:15 GMT (envelope-from gavin@FreeBSD.org) X-Authentication-Warning: buffy.york.ac.uk: ga9 set sender to gavin@FreeBSD.org using -f From: Gavin Atkinson To: John Baldwin In-Reply-To: <200902031614.n13GEbAt034978@svn.freebsd.org> References: <200902031614.n13GEbAt034978@svn.freebsd.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 03 Feb 2009 16:45:15 +0000 Message-Id: <1233679515.51684.60.camel@buffy.york.ac.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 FreeBSD GNOME Team Port X-York-MailScanner: Found to be clean X-York-MailScanner-From: gavin@freebsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r188077 - in head/sys/dev: ichsmb ipmi smbus X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2009 16:45:23 -0000 On Tue, 2009-02-03 at 16:14 +0000, John Baldwin wrote: > Author: jhb > Date: Tue Feb 3 16:14:37 2009 > New Revision: 188077 > URL: http://svn.freebsd.org/changeset/base/188077 > > Log: > - Change ichsmb(4) to follow the format of all the other smbus controllers > for slave addressing by using left-adjusted slave addresses (i.e. > xxxxxxx0b). Thank you! This is kern/100513 (although the PR believed that ichsmb was the correct one, not the one at fault). >From my experience, the way FreeBSD now do it seems to be the "more standard" way, in that I2C datasheets usually give the xxxxxxx0b address as the device address, however NetBSD (at least) seems to use the address in the MSB=0 form. I suspect this is probably worth documenting explicitly somewhere. Gavin