From owner-freebsd-current@FreeBSD.ORG  Sun Aug 28 23:38:02 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C7CD7106566B;
	Sun, 28 Aug 2011 23:38:02 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com
	[209.85.216.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 6E77D8FC08;
	Sun, 28 Aug 2011 23:38:02 +0000 (UTC)
Received: by qyk9 with SMTP id 9so3789320qyk.13
	for <multiple recipients>; Sun, 28 Aug 2011 16:38:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	bh=y4ejyttmMnarBar49ngZHsctHuh9aCemPPaOEJ99TJQ=;
	b=b78xcDei06KaK3pZpihwzPwR6z0SPMe5uWltxgDE9XxUNQvH63xxH8Sa1JpLme0Pu2
	7mPoV+Dt+ucR3vd7C8ttFL4QzWcUb1/rBCfV9QLfyaklbOr4w9wvbZU2b2cAiI8wCglk
	6tx4qC6gPbl7qy2vYsxcCBHYYaxlbompeSKKU=
MIME-Version: 1.0
Received: by 10.224.98.8 with SMTP id o8mr801170qan.379.1314574681673; Sun, 28
	Aug 2011 16:38:01 -0700 (PDT)
Received: by 10.224.19.131 with HTTP; Sun, 28 Aug 2011 16:38:01 -0700 (PDT)
In-Reply-To: <CAJ-VmonnTxoWMbRE-PqtoDH1_16OpwK0Jw9hZ6WVkQjnr-JTfw@mail.gmail.com>
References: <CAGH67wRz6X=ZU0AZFM1G-fo=NKHNVV7SD547KD-BBp4VOofDaw@mail.gmail.com>
	<CAJ-VmonnTxoWMbRE-PqtoDH1_16OpwK0Jw9hZ6WVkQjnr-JTfw@mail.gmail.com>
Date: Sun, 28 Aug 2011 16:38:01 -0700
Message-ID: <CAGH67wSX3d8AM+-Qc_M2RfBL_VMyRPB7na_JmNxq2nfb4fL0Bg@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: if_ath - should it be compiled without ath_hal support?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Aug 2011 23:38:02 -0000

On Wed, Aug 24, 2011 at 10:37 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> Hi,
>
...

> Well, the ath_hal code should be built in as part of the ath module.
> ath needs ath_hal to speak to the MAC/baseband/radio. There's no need
> for #ifdef's to guard them as .. well, they're needed.

Ok.

> I'd like to eventually split out the ath_hal again into a separate
> module and re-instate the separation between HAL and driver code
> (primarily to enforce cleaner code and more stable APIs.)

Good to know. I was just a bit confused with the manpages that say
they're optional after I discovered looking at the driver that they're
hardwired in.

> If you're seeing issues like the above, chances are that you're seeing
> some corruption. Can you please print out the whole value of *rs (ie,
> all the fields of the ath_rx_status struct) so I can see how valid it
> is?

Sure:

(kgdb) p *rs
$1 =3D {rs_datalen =3D 244, rs_status =3D 0 '\0', rs_phyerr =3D 0 '\0',
rs_rssi =3D 0 '\0', rs_keyix =3D 127 '\177', rs_rate =3D 27 '\033', rs_more
=3D 0 '\0', rs_tstamp =3D 2097280, rs_antenna =3D 8399232, rs_rssi_ctl =3D
"0\200)", rs_rssi_ext =3D "\200\000\037", rs_isaggr =3D 1 '\001',
rs_moreaggr =3D 1 '\001', rs_num_delims =3D 0 '\0', rs_flags =3D 252 '=FC',
rs_evm0 =3D 0, rs_evm1 =3D 0, rs_evm2 =3D 0, rs_evm3 =3D 0, rs_evm4 =3D 0}

Thanks!
-Garrett