From owner-svn-src-head@FreeBSD.ORG  Thu Oct 11 05:00:35 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 301B1B5C;
 Thu, 11 Oct 2012 05:00:35 +0000 (UTC)
 (envelope-from davide.italiano@gmail.com)
Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com
 [209.85.220.182])
 by mx1.freebsd.org (Postfix) with ESMTP id D986C8FC12;
 Thu, 11 Oct 2012 05:00:32 +0000 (UTC)
Received: by mail-vc0-f182.google.com with SMTP id fw7so2151712vcb.13
 for <multiple recipients>; Wed, 10 Oct 2012 22:00:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=ZkmrbfVPCTLP8C/Mw56sLIDe5Dh8Q8RJuYTEROEpQQk=;
 b=gHkA8CoNYuER50qrkZCoumb5E+DlX0Pp8Y+8VoFjkyn/hI/yppAXKlzWgxVPy+5sPV
 HS3B+3luQKX6WEWx25UDS6nLixzYVO/87e+eGGq8QM2InwKXPKrSD6HjvBApPfUfIfJF
 YI4ywIKKEwcuib01XivHlWKPLkNyRmsDRqwNChgqa/5/a1UM8/saREI6Jl0CeGER0Gap
 Dhr4kEHWxBjJafxr7CWpbEThNTygdIPovDtCmIUqzSCPHnyMcQx1AgM0xALuIWjx70Qf
 ILnRYXXcPmYvWyIbqL9eFEvvNc0eFOQ6pMRSJJ+tivmtFGiPaASJ+W+8UiDOUUF8Adax
 /dkQ==
MIME-Version: 1.0
Received: by 10.220.115.138 with SMTP id i10mr10941281vcq.37.1349931626590;
 Wed, 10 Oct 2012 22:00:26 -0700 (PDT)
Sender: davide.italiano@gmail.com
Received: by 10.58.247.132 with HTTP; Wed, 10 Oct 2012 22:00:26 -0700 (PDT)
In-Reply-To: <5006A7DD.9050509@FreeBSD.org>
References: <201207162207.q6GM7UNS087234@svn.freebsd.org>
 <CAJ-FndA+EEr9OfoRz6+BP7sk_3+drxWx0zs4WbQhMLq9A0D_Pw@mail.gmail.com>
 <5006A7DD.9050509@FreeBSD.org>
Date: Thu, 11 Oct 2012 07:00:26 +0200
X-Google-Sender-Auth: HV6bh30gsTzcSNKy7qUnuDinK74
Message-ID: <CACYV=-Ej1o2cQnU4WzKtFkb3M++zKLBuMdH+T-ASmRomogzp-w@mail.gmail.com>
Subject: Re: svn commit: r238539 - head/sys/fs/smbfs
From: Davide Italiano <davide@freebsd.org>
To: Christian Brueffer <brueffer@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: attilio@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Mateusz Guzik <mjg@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Oct 2012 05:00:35 -0000

On Wed, Jul 18, 2012 at 2:11 PM, Christian Brueffer
<brueffer@freebsd.org> wrote:
> On 7/17/12 0:10 , Attilio Rao wrote:
>> 2012/7/16 Christian Brueffer <brueffer@freebsd.org>:
>>> Author: brueffer
>>> Date: Mon Jul 16 22:07:29 2012
>>> New Revision: 238539
>>> URL: http://svn.freebsd.org/changeset/base/238539
>>>
>>> Log:
>>>   Simply error handling by moving the allocation of np down to where it is
>>>   actually used.  While here, improve style a little.
>>
>> Too bad that the biggest bug here is still in place.
>> Right now smbfs inserts in the mount list half-constructed vnodes.
>> Maybe you are interested in fixing this?
>>
>
> I can give it a shot, no promises though.
>
> Cheers,
>
> Chris
>

This patch should fix the half-constructed vnode insertion issue.
Can you give it a look, Attilio?
http://people.freebsd.org/~davide/ix/smbfs_norollhash.diff
Moreover, it makes the code relying on the global vfs_hash table, now
it works using an home-made local hash table for vnodes.

Thanks

Davide