From owner-freebsd-ports  Thu May 30 02:41:28 1996
Return-Path: owner-ports
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id CAA15743
          for ports-outgoing; Thu, 30 May 1996 02:41:28 -0700 (PDT)
Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id CAA15716
          for <ports@freebsd.org>; Thu, 30 May 1996 02:41:22 -0700 (PDT)
Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.7.5/8.6.9) id CAA02402; Thu, 30 May 1996 02:41:15 -0700 (PDT)
Date: Thu, 30 May 1996 02:41:15 -0700 (PDT)
Message-Id: <199605300941.CAA02402@silvia.HIP.Berkeley.EDU>
To: jkh@time.cdrom.com
CC: ports@freebsd.org
In-reply-to: <16316.833412688@time.cdrom.com> (jkh@time.cdrom.com)
Subject: Re: Request for feedback:  REQUIRES_OS_VERSION feature.
From: asami@cs.berkeley.edu (Satoshi Asami)
Sender: owner-ports@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

 * If this variable is set in a Makefile, the output of `uname -r' will
 * be compared against it and, if no match occurs, refuse to build
 * the port.  For example, the top port could have:
 * 
 * REQUIRES_OS_VERSION=    2.2
 * 
 * For all variants and 2.1 users could make from the -current tree with
 * impugnity, any ports like top simply getting skipped.

I think this is fine.

 * [diffs relative to -current]

This needs a major cleanup though. ;)

First, disabling reinstall based on NO_INSTALL is not necessary, as
reinstall calls install and that will be disabled by NO_INSTALL.

Next, check sitting between configure and build is simuly bogus, if
it's not suitable for the user's system, it shouldn't attempt to do
anything.  Having a missing dependency (configure -> check) and
calling configure from check is a pretty gross hack too.

What we should probably do is to add it to the beginning before
fetch, so it can also be used for other things (security/ssh's
USA_RESIDENT check comes to mind).  Let me look into this.

Satoshi