From owner-freebsd-ports@FreeBSD.ORG Wed Aug 29 19:59:31 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C41391065670; Wed, 29 Aug 2012 19:59:31 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6B40B8FC14; Wed, 29 Aug 2012 19:59:31 +0000 (UTC) Received: by ialo14 with SMTP id o14so2360588ial.13 for ; Wed, 29 Aug 2012 12:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=yGLL3cUwsSbXedE1eJIyGpwuTUmxaTbxY3Gg0slM1c4=; b=XgPp7vw7qWJnt3EG4R+P1NkSRbcXFqyfUk++WxjK1GIikZLZwzCUAa30xsOeK5d8qo mVD5JKXmrpws9EstIoqvZ6VjEieTnOM/nbzUvi3PSms15xE5uggucOkuDXIq0VnF4uOy b+ldf4pIxCbAZ8+/AOaFvY5raIIphFqg0BREBf+nYZA1gBl0qaXPZGoh+6Kfj4+wXuiF 1vFo2t2e59HIGaCiDJFA3bQIfKTHpSjtzO7CtW8jtPH0HB4tEzKxDJbl61yS2PdKts6q 9zKx4lbO5Jugdy/mE8wd8/+EioXEFH5mVgd+WyGlzvRVll9mq17MdzdYZF1gL3wSx2k6 2DCA== MIME-Version: 1.0 Received: by 10.50.186.165 with SMTP id fl5mr3115667igc.47.1346270370869; Wed, 29 Aug 2012 12:59:30 -0700 (PDT) Received: by 10.64.14.211 with HTTP; Wed, 29 Aug 2012 12:59:30 -0700 (PDT) In-Reply-To: <20120829214831.000050c8@unknown> References: <20120826225435.00005a10@unknown> <20120829211753.0000399e@unknown> <20120829214831.000050c8@unknown> Date: Wed, 29 Aug 2012 12:59:30 -0700 Message-ID: From: Garrett Cooper To: Alexander Leidinger Content-Type: text/plain; charset=ISO-8859-1 Cc: ports@freebsd.org, Eitan Adler , portmgr@freebsd.org Subject: Re: Regression in PREFIX handling in packages X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2012 19:59:31 -0000 On Wed, Aug 29, 2012 at 12:48 PM, Alexander Leidinger wrote: > On Wed, 29 Aug 2012 15:28:36 -0400 Eitan Adler > wrote: > >> On 29 August 2012 15:17, Alexander Leidinger >> wrote: >> > Could it be that my problem comes from r231300 and I was lucky that >> > I didn't create a package on the machine with the >> > symlinked /usr/local and used it on a machine with a >> > normal /usr/local? Symlinking would be a problem if you built it on one machine and installed it on another. ... > Wouldn't it be better to use > ---snip--- > if (Prefix[0] != '/' && realpath(... > ---snip--- > in this case? Attention: I just guessed what Prefix is and what it > should contain by looking at the diff, I didn't had a look at the > declaraction and assignments of Prefix. That would cause problems in some cases where someone called pkg_create -p /usr/foobar/../local If this commit causes more harm than good, please back it out -- pkg_install is going to die soon anyhow, so I'd rather not fritter away time debating its usefulness if it breaks a valid use case. Thanks, -Garrett