From owner-svn-src-head@freebsd.org Mon Jun 4 05:45:01 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA45FFF53B0; Mon, 4 Jun 2018 05:45:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6918073A1B; Mon, 4 Jun 2018 05:45:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 32191113E9; Mon, 4 Jun 2018 05:45:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id 6ED0246D2F; Mon, 4 Jun 2018 07:45:00 +0200 (CEST) Date: Mon, 4 Jun 2018 07:45:00 +0200 From: Baptiste Daroussin To: Florian Smeets Cc: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334474 - head/usr.bin/top Message-ID: <20180604054500.zqcnqmyuu6mjxn7t@ivaldir.net> References: <201806010551.w515pfoB090926@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="joi4svscitjrb5vi" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180323 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 05:45:01 -0000 --joi4svscitjrb5vi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 03, 2018 at 07:19:47PM +0200, Florian Smeets via svn-src-all wr= ote: > On 01.06.18 07:51, Eitan Adler wrote: > > Author: eadler > > Date: Fri Jun 1 05:51:40 2018 > > New Revision: 334474 > > URL: https://svnweb.freebsd.org/changeset/base/334474 > >=20 > > Log: > > top(1): Display of TID when using 'H' flag > > =20 > > Some users prefer seeing the TID when viewing individual threads. This > > makes sense as the PID will be the same for multiple entries. An atte= mpt > > was made to include both, but there is insufficient room. As such, us= ing > > the TID. > > =20 > > While here, rename the header variables to be more understandable. > > =20 > > Discussed with: mmacy > > Reported on: 2009-10-07 > >=20 >=20 > Hi, >=20 > I think this is a mistake. The 'H' flag should keep the PID, AFAIK you > cannot use the TID anywhere in top in contrast to the PID. I usually > start top with the 'S' and 'H' flags. Now I cannot use 'k' to kill a > process in that view, as I don't see the PID. IMHO showing TIDs should > be a separate flag, 'h' maybe, as this commit changes current/expected > behavior (POLA?). >=20 > Also, this is not documented in the man page. >=20 > Florian >=20 I fully agrees here! Bapt --joi4svscitjrb5vi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlsU0dwACgkQY4mL3PG3 Plonfg/+MZeWDrPqcdqdQham5uVBZdGJXqcpPMb4fpxn+RdgNAL+S42+Cq0g0N7K 8/0CT+ewxsiKGoE1pCkFPvmcA2H9hKpFzj+DGAC8TOn12zxvRFU2MC1lsw8OC62O fbsfhysePBpbS4T5y9+9PmnZ7uI/ERPwuzOXmEJ6CKHZkKbTo7NnavocSxT7h0D0 JEtDSW6abMN4XQOm+7584aarPZUdhUqkumA/jf7qpoVlKe2eefSDMuiFUc1CDIBt vF+uX96GIOco+uJ9QGTqoA65akI+ZUE5MDMTRxtRzRth+tYdHKfUSpg+LIrb5M9h XoEDJnKn/ZIvzr3bDscWOm64lNQepJ3dU55K4+cTkEwC76yptPtWV6kM/r29+qWO liOw5qZFPfFX51y2gmZK1M6vQL0oA0qXc1MyrlChoYSeTMBBlFN3g0x8dV84ls/d GYmqHAwh38iqZy21MeZW0PDlUP2r+K8dVNfq9Zws2J2sDY4IRclYbDSWtru/yZW5 FbIv9zZ0+ypm4mLCG0g2gEpxQUpzfAvisl5DxEnFvlFrkI32TM7C+9hrdJC7Q1+Z t0HIbnGSg0mwnHsIsujBbcai/4dyrJxaDaez9T3Naw9e00g36PBEEJ1/h/0zt5Ve IUv7V7V8WqwerF9eUTuL0nH9HDRfMZc7BaZnAeS3+wvjMY8tZeg= =AhVh -----END PGP SIGNATURE----- --joi4svscitjrb5vi--