From nobody Tue Nov 26 20:36:38 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XyZ9f59Nfz5dywQ for ; Tue, 26 Nov 2024 20:36:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XyZ9f33c5z45h2 for ; Tue, 26 Nov 2024 20:36:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732653398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hxswF2Om88LhNL5+Fepl8pBnH7sV+ArMPFJ5d4BchfY=; b=xwxIpdqo/WVhGY8Acjty8RwW53yEOBfJYV8CGNckw0t/58UK/7xhSsvbTbeqv8Ox4uMkzP NOZGi2DjaV2GyGlcKZz3dz2HCqtEyuRDEwzBkPxZ0rb4PIq+3U5XrVBFy6YR9kjvQpmtsS 8L1GMz+PXfz6QkSoTq9y3CoFHTtN5n362LvETE0XfCf3k4y0wPsYXaepW7cLya+RfXthlD DoOF3VIQOsOp9HcKYb7wdmrJRF/13FhelNrKyYbp54ac5VY7W/wTENz8/zqjAPDtpdvqMM 2idanWx4AlhnQtPG/sT7XOmQ2bp7wbWxvIpx5hBNavct7eyroMHs5gjhAfuR+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732653398; a=rsa-sha256; cv=none; b=prq6dDL32fW7HQZqsCuFQQsanyBQWvdtLYexlJ+7E4orXQGpnFsU5dHC4hxMddx87r8MVM UOVT51vGGY91pHSzSo/OTLAdnbse4hZvdMzZbduEGky0L0TFmp9sz2QHxz1y0k1moSY9O0 rEeSGhET/YGiTrgwtt+cctOtraPozOlYumXqieZx1qe5pM4rYzGHcqlLu52H/ha8WGC0p9 9pliigQA9TV9M6badv8yC23meM29Vh73BL6s0fcRqwEjiRwfiBBhMMy8E8VZtcrTnlx4e5 BMCTuUSg4pz1BdUpsl9DqoLiUn+cSYHb6dY2JRgOs70+n8GRHARRQBtjC5SJow== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XyZ9f2f90zg1h for ; Tue, 26 Nov 2024 20:36:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4AQKacLo042717 for ; Tue, 26 Nov 2024 20:36:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4AQKacYE042716 for ports-bugs@FreeBSD.org; Tue, 26 Nov 2024 20:36:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 282733] [NEW PORT] textproc/dmenu-translate: Quick text translation with dmenu Date: Tue, 26 Nov 2024 20:36:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282733 --- Comment #5 from Robert Clausecker --- Thanks. If you can't use base sed, using GNU sed should be fine. As for your current patch, it looks better. Some things that need to be fi= xed: - do not invent a version number when upstream doesn't have one, instead follow the example given in =C2=A7 5.4.3 "USE_GITHUB" Example 17. - use the full git hash for GH_TAGNAME so it's unambiguous in any case - prefer DISTVERSION over PORTVERSION if possible - please check the grammar of your option descriptions; perhaps something = like this would work? WAYLAND_DESC=3D depend on x11/wmenu and x11/wl-clipboard for use with W= ayland X11_DESC=3D depend on x11/dmenu and x11/xclip for use with X11 - our mktemp does not support --tempdir. Please check the manual. Perhaps you want "mktemp -d dmenu-translate.XXXXXX' Please check and resubmit if possible. I'm sorry for not catching these is= sues earlier. --=20 You are receiving this mail because: You are the assignee for the bug.=