From owner-p4-projects@FreeBSD.ORG  Tue Apr 25 15:12:59 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6075E16A401; Tue, 25 Apr 2006 15:12:59 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 005EB16A405;
	Tue, 25 Apr 2006 15:12:58 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 05FA143D48;
	Tue, 25 Apr 2006 15:12:57 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost (john@localhost [127.0.0.1])
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k3PFCsRd061673;
	Tue, 25 Apr 2006 11:12:56 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: John Birrell <jb@freebsd.org>
Date: Tue, 25 Apr 2006 11:06:49 -0400
User-Agent: KMail/1.9.1
References: <200604242332.k3ONWeRq008991@repoman.freebsd.org>
In-Reply-To: <200604242332.k3ONWeRq008991@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200604251106.50641.jhb@freebsd.org>
X-Virus-Scanned: ClamAV 0.87.1/1425/Tue Apr 25 08:09:41 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 96028 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Apr 2006 15:12:59 -0000

On Monday 24 April 2006 19:32, John Birrell wrote:
> http://perforce.freebsd.org/chv.cgi?CH=96028
> 
> Change 96028 by jb@jb_freebsd2 on 2006/04/24 23:32:39
> 
> 	The latest hacks.
> 
> Affected files ...
> 
> .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_hacks.h#7 edit
> 
> Differences ...
> 
> ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_hacks.h#7 (text+ko) ====
> 
> @@ -18,12 +18,20 @@
>  void vmem_free(vmem_t *, void *, size_t);
>  void vmem_destroy(vmem_t *);
>  
> +#undef curthread
> +#define curthread       	((struct thread *) PCPU_GET(curthread))\

This is odd, why did you do this?  Note that the cast shouldn't be needed
for one, and that curthread is already basically defined to be this (though
tweaked to optimize the kernel build for some archs like i386 and amd64).

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org