From owner-svn-src-head@FreeBSD.ORG Sun Mar 16 16:39:36 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CF99C8D1; Sun, 16 Mar 2014 16:39:36 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9025AB1D; Sun, 16 Mar 2014 16:39:36 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s2GGdZZQ087492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 16 Mar 2014 09:39:35 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s2GGdZNd087491; Sun, 16 Mar 2014 09:39:35 -0700 (PDT) (envelope-from jmg) Date: Sun, 16 Mar 2014 09:39:35 -0700 From: John-Mark Gurney To: Robert Watson Subject: Re: svn commit: r263215 - head/sys/crypto/sha2 Message-ID: <20140316163935.GD32089@funkthat.com> References: <201403160057.s2G0vQEh074159@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Sun, 16 Mar 2014 09:39:35 -0700 (PDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Mar 2014 16:39:36 -0000 Robert Watson wrote this message on Sun, Mar 16, 2014 at 10:20 +0000: > On Sun, 16 Mar 2014, Robert Watson wrote: > > >> copy these files from lib/libmd in preperation for moving these files > >> into the kernel... > > > >I was sure that there was a sha256 implementation in the kernel already, > >and indeed there is -- in the ZFS code. Having it in the crypto tree > >makes (much) more sense (and I remain surprised it wasn't there already). > >I wonder if this means we can GC at least the copy in the zfs tree (if not > >the boot copy as well). > > Reading the follow-up commit I now understand better. I do wonder if we > can drop the ZFS copy, however -- in general, we seem to prefer FreeBSD > versions of things (e.g., the ACL code) when they are available. Which one are you talking about? If you are talking about the one in sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sha256.c, that is just a wrapper around the one I just improved/replaced... If you are talking about the one in sys/cddl/boot/zfs/sha256.c, that, I assume, is part of the boot code, and would require special handling.. plus, boot code doesn't need to run fast, and usually needs to be smaller, though once I add the option of rolling the loops up, we could look at that... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."