From owner-dev-commits-src-main@freebsd.org Tue Feb 9 15:49:31 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 69141542E4C; Tue, 9 Feb 2021 15:49:31 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DZnQ326Xhz3CWD; Tue, 9 Feb 2021 15:49:31 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x433.google.com with SMTP id n6so9703195wrv.8; Tue, 09 Feb 2021 07:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DO/xrr/FDDW+KvbXc9O4rn6h9X/VxjxustXOllagqQ4=; b=sVB4NbtMgGtQCEir8obC9yXMMe1xNw3ayV7ZFmE/73XaxLRcocHen7n7SS4EuMYoE4 lAYwm3Sim3yLkPmLJnhsY9kN8obbQpIOMGBylgfNUYPyhidRBunSJVVmf/YU/j3E7NsR HUMULrbQn6XBgg05EGIpGRqcLV5KJLWJJHMI1B2mCLJmkSVYAs9evQdHtOBnmw3S4U3O gpZuhd7gHiGlXC5q1JBnyZzj+7/XPjw27YdqTmicBVae0xTUQowB47eUwhNZoFTBdHGA oqdWi4EYt3XbZlR1hXie8v1iia4/fnkFivrg9PJH3G82WHq1zMjJLhzXAeVf6gIp8dlK A7mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DO/xrr/FDDW+KvbXc9O4rn6h9X/VxjxustXOllagqQ4=; b=Zio4TsDimngHpEX3xFVoEG8tAXEZMW2hOYsiSQfIEXKbXyIpzMbllldCXlsq/ehlFN 4ljq7k7d37LniqNi1Pvw1I8pxsSjmKIfcE42Gz87sz280cSV/5T+S1VEE97QlR6k/+bM C65hVLogU4Lpie+BygtG77eS7E/5gWiqPMoYxjKjfa29AUeP4fZ6i4wpSPtN9m1VxGz4 aTSbXZoN7z1u00tHo+VlxWPU1Q78M4ge0asDxKwL7Xe9kD8ISwCtjElEGY3IxQgdN80B SA0BKKQe+VHyB7+F7JzfsyCEiBHR/bmrDBSpafnB0vEDls25WBbHsFF2phvXPRyfM/8C 7MpQ== X-Gm-Message-State: AOAM530qAUNYBgN/M9tGwFrUWWm2sR1K4JhylN1XUtrnOQixyFzcYjDu JGt/B8/nOOYtPr9LI7ufjke/wpUKUqrq9YiaYtOHpc7HGn4= X-Google-Smtp-Source: ABdhPJwAckRthV9kB61m+7DAHR+wABUhIqlUtb52fEeKHeu8tpUxlmlvLyLeajtNcw2SXAmsOE2dCN3QcydxxOJOsr4= X-Received: by 2002:a5d:5248:: with SMTP id k8mr2983563wrc.17.1612885769930; Tue, 09 Feb 2021 07:49:29 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:464c:0:0:0:0:0 with HTTP; Tue, 9 Feb 2021 07:49:28 -0800 (PST) In-Reply-To: <83E33E2F-F7FE-4385-8F99-0A7235F87C63@freebsd.org> References: <202102081915.118JFXkJ067892@gitrepo.freebsd.org> <83E33E2F-F7FE-4385-8F99-0A7235F87C63@freebsd.org> From: Mateusz Guzik Date: Tue, 9 Feb 2021 16:49:28 +0100 Message-ID: Subject: Re: git: af366d353b84 - main - amd64: implement strlen in assembly To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DZnQ326Xhz3CWD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 15:49:31 -0000 On 2/9/21, Jessica Clarke wrote: > Here's your review after reading through it for <5 minutes today: > > On 8 Feb 2021, at 19:15, Mateusz Guzik wrote: >> + leaq (%r11,%r8),%rcx >> + notq %r11 >> + andq %r11,%rcx >> + andq %r9,%rcx >> ... >> + leaq (%r11,%r8),%rcx >> + notq %r11 >> + andq %rcx,%r11 > > These look the wrong way round (but you got it the right way round > above). > Indeed, solid brainfart. Interesting this still passed the test suite. Thank you for noting this. However, your response does not really address any of the points I raised in my e-mail. >> + andq %r9,%rcx > > Jess > > -- Mateusz Guzik