From owner-cvs-all@FreeBSD.ORG Tue Oct 11 02:30:36 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E7401065687; Tue, 11 Oct 2011 02:30:36 +0000 (UTC) (envelope-from ache@vniz.net) Received: from vniz.net (vniz.net [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 5FFBC8FC19; Tue, 11 Oct 2011 02:30:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vniz.net (8.14.5/8.14.5) with ESMTP id p9B2UXUF049639; Tue, 11 Oct 2011 06:30:34 +0400 (MSK) (envelope-from ache@vniz.net) Received: (from ache@localhost) by localhost (8.14.5/8.14.5/Submit) id p9B2UXMg049638; Tue, 11 Oct 2011 06:30:33 +0400 (MSK) (envelope-from ache) Date: Tue, 11 Oct 2011 06:30:33 +0400 From: Andrey Chernov To: Eitan Adler Message-ID: <20111011023032.GA24089@vniz.net> Mail-Followup-To: Andrey Chernov , Eitan Adler , cvs-ports@FreeBSD.ORG, ports-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <201110101738.p9AHcHUq031559@repoman.freebsd.org> <20111010194330.GA94990@vniz.net> <20111010215854.GA96634@vniz.net> <20111011002607.GE21265@magic.hamla.org> <20111011010644.GA19242@vniz.net> <20111011012758.GA26511@vniz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: cvs-ports@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/x11/luit Makefile distinfo ports/x11/luit/files patch-luit.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2011 02:30:36 -0000 On Mon, Oct 10, 2011 at 10:10:01PM -0400, Eitan Adler wrote: > > Note: this is true for old FreeBSD versions without /dev/pts, i.e. for > > FreeBSD < 8. Since old versions will die soon, perhaps choosen default > > isn't so bad. > > The default was chosen before I joined x11@ and I have not reviewed > this port for security issues. If this is still a concern can you > please email x11@ with your report so more people can comment? Not for me. Running 9-stable I still have WITH_SETUID_LUIT in my /etc/make.conf historically, so notice -DBSD absense immediately, but WITH_SETUID_LUIT is unneded since /dev/pts. I think luit port Makefile warning about WITH_SETUID_LUIT should be OSVERSION-dependent. -- http://ache.vniz.net/