From owner-svn-ports-head@FreeBSD.ORG  Wed Jul 30 16:08:43 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 31BF3663; Wed, 30 Jul 2014 16:08:43 +0000 (UTC)
Date: Wed, 30 Jul 2014 16:08:43 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r363361 - in head/editors/fte: . files
Message-ID: <20140730160843.GA2688@FreeBSD.org>
References: <201407291646.s6TGkjHH090335@svn.freebsd.org>
 <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org>
 <20140730070412.GA97692@FreeBSD.org>
 <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk>
 <53D89EBF.4080805@marino.st>
 <2D24420529C9ECAEABB9A791@atuin.in.mat.cc>
 <53D8A2BB.7090704@marino.st>
 <6270029E710D3C52B60B6224@atuin.in.mat.cc>
 <20140730081413.GA29876@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140730081413.GA29876@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>,
 svn-ports-all@freebsd.org, marino@freebsd.org,
 William Grzybowski <wg@freebsd.org>, ports-committers@freebsd.org,
 Adam Weinberger <adamw@adamw.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jul 2014 16:08:43 -0000

On Wed, Jul 30, 2014 at 08:14:14AM +0000, Alexey Dokuchaev wrote:
> On Wed, Jul 30, 2014 at 10:08:05AM +0200, Mathieu Arnold wrote:
> > But, I think you're missing the point, who cares what the separator is ?
> > All it needs to do is work when I run make patch. Also, all one needs to
> > know is that to generate the patches, you run make makepatch.
> 
> Well, if you don't care, then I guess you won't mind if we change it to
> something more appealing to those who do care.

Given some thought over it, I propose the following changes to makepatch:

  - default to dash (minus, '-')
  - provide a command line option (-s?) or make(1) variable (PATH_SEPARATOR)
    to override it when needed
  - assert that forced value is not something insane ('__', '::', '../../',
    etc.) -- basically, match it over a prerefined list of acceptable values

I can cook up a patch unless John had beaten me on that already.

./danfe