Date: Mon, 13 Jan 2020 22:36:24 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Jeff Roberson <jeff@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356714 - head/sys/ufs/ffs Message-ID: <7c2872cd-3178-8cf0-ee47-7aea7f00285b@FreeBSD.org> In-Reply-To: <202001140200.00E20OY4086656@repo.freebsd.org> References: <202001140200.00E20OY4086656@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13/01/2020 21:00, Jeff Roberson wrote: > Author: jeff > Date: Tue Jan 14 02:00:24 2020 > New Revision: 356714 > URL: https://svnweb.freebsd.org/changeset/base/356714 > > Log: > Fix a long standing bug in journaled soft-updates. The dirrem structure > needs to handle file removal, directory removal, file move, directory move, > etc. The code in handle_workitem_remove() needs to propagate any completed > journal entries to the write that will render the change stable. In the > case of a moved directory this means the new parent. However, for an > overwrite that frees a directory (DIRCHG) we must move the jsegdep to the > removed inode to be released when it is stable in the cg bitmap or the > unlinked inode list. This case was previously unhandled and caused a > panic. > > Reported by: mckusick, pho > Reviewed by: mckusick > Tested by: pho MFC ? I mean if it's a long standing bug + unhandled + causing a panic ... sounds like it really should be merged. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7c2872cd-3178-8cf0-ee47-7aea7f00285b>