Date: Fri, 03 Jan 2020 15:50:06 +0100 From: Adriaan de Groot <adridg@freebsd.org> To: Devin Teske <dteske@freebsd.org>, Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, dteske@freebsd.org Subject: Re: svn commit: r521892 - in head/math: . R-cran-alabama Message-ID: <2968169.bT80LyP3VS@beastie.bionicmutton.org> In-Reply-To: <20200103083628.b7b2b46pea33vu5f@atuin.in.mat.cc> References: <202001030056.0030umrE001847@repo.freebsd.org> <20200103083628.b7b2b46pea33vu5f@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart15631837.vxEf1mJfsr Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Friday, 3 January 2020 09:36:28 CET Mathieu Arnold wrote: > On Fri, Jan 03, 2020 at 12:56:48AM +0000, Devin Teske wrote: > > Author: dteske (src committer) > > As stated by this ^^^^^^^^^^^^^ you are not a ports committer. So you > are required to get approval, and state the approval in your commits, > saying it has been reviewed is not enough. > > > Reviewed by: mat, imp (previous revision) > > Differential Revision: https://reviews.freebsd.org/D22675 Question for mat@, just to be clear: the issue here is (only) that there should be an extra line in the commit message, Approved by: mat or possibly Approved by: mat (mentor) as described in the committer's guide [1]. The Phab review was approved (accepted), so it's just the documentation of process? [1] https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ commit-log-message.html [ade] --nextPart15631837.vxEf1mJfsr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEUq+pvuD+N8/vVW++WoDe9T7W/7IFAl4PVJ4ACgkQWoDe9T7W /7KBWg//T0ARPWt3ltmK/RNxh2q9t0cfpCwuJX4X2DpwJ7Q7fMUuVgsMx29xtEJw GQLU60Fkwp0R9q524hVXWNCukOiofjiz6IuLc/3T6pdprDRjqBW7wHDdJgbQCB1f LIjtVrb1XBRGFpHvdDQ5tXe3y6CVVzw/m25y0FWyn4f6f6QFhNnjzgLe0P+GS1VR NQIpMD/F0A+GVSOxuDXS1KOFxWOtxX+GltbpaPnrH37DYmoNNiOgIC7x0JQ+8X7U MVzstomFO734APA9Pes2L9XIEBVr8zFYXQfuWGXRuWhDTmfJbeW+LFrUwUdEA9/i y1r3S1QDQg9xynJTdeUmkQg/1rqeHA77kMBcHIYuVqhKG2BtP091BDm+Ntm6A7Ze iqIF7KU3yl+zPcr9jnrClC7DFbaW7zcF8Zks6IZPbahmCLg41seLVgtljK+4iXTc QL+1rKQvvDGwykiqZqhU5RabUdeT1+Wz9DbHjIuxgEd3Bl1pUdOA8YjqH+FauwYH N/Os5ArNm7KwfMNxxFpOHVENX+qtVJ6PYmOjFJb6gHYmY6bUIjil1sSvHMhl0kio sMdcafJy+71cEszv4LPtEFhHvE3loT4oUanCMozNCiBbLqibXz+1eGhGf0A8gsoL qs/ROy4sbbQCIv1VcFh9nrw0HHaSj85z1/y9EZNoTJHClMOQq7k= =r84h -----END PGP SIGNATURE----- --nextPart15631837.vxEf1mJfsr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2968169.bT80LyP3VS>