From owner-svn-src-head@freebsd.org Mon Jan 29 18:09:47 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEB4BED56F4; Mon, 29 Jan 2018 18:09:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A68E97E832; Mon, 29 Jan 2018 18:09:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 05BF110A87D; Mon, 29 Jan 2018 13:09:40 -0500 (EST) From: John Baldwin To: Michal Meloun Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328511 - head/sys/dev/extres/clk Date: Mon, 29 Jan 2018 09:46:02 -0800 Message-ID: <4499401.WAFztV9qgp@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201801281520.w0SFKjQe067446@repo.freebsd.org> References: <201801281520.w0SFKjQe067446@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 29 Jan 2018 13:09:40 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 18:09:47 -0000 On Sunday, January 28, 2018 03:20:45 PM Michal Meloun wrote: > Author: mmel > Date: Sun Jan 28 15:20:45 2018 > New Revision: 328511 > URL: https://svnweb.freebsd.org/changeset/base/328511 > > Log: > diff --git a/sys/dev/extres/clk/clk.c b/sys/dev/extres/clk/clk.c > index c6a1f466ceb..c3708a0ce27 100644 > --- a/sys/dev/extres/clk/clk.c > +++ b/sys/dev/extres/clk/clk.c > @@ -642,10 +642,11 @@ clknode_adjust_parent(struct clknode *clknode, int idx) > if (clknode->parent_cnt == 0) > return; > if ((idx == CLKNODE_IDX_NONE) || (idx >= clknode->parent_cnt)) > - panic("Invalid clock parent index\n"); > + panic("%s: Invalid parent index %d for clock %s", > + __func__, idx, clknode->name); > > if (clknode->parents[idx] == NULL) > - panic("%s: Attempt to set invalid parent %d for clock %s", > + panic("%s: Invalid parent index %d for clock %s", > __func__, idx, clknode->name); > > /* Remove me from old children list. */ > @@ -674,8 +675,8 @@ clknode_init_parent_idx(struct clknode *clknode, int idx) > if ((idx == CLKNODE_IDX_NONE) || > (idx >= clknode->parent_cnt) || > (clknode->parent_names[idx] == NULL)) > - panic("%s: Invalid clock parent index: %d\n", __func__, idx); > - > + panic("%s: Invalid parent index %d for clock %s", > + __func__, idx, clknode->name); > clknode->parent_idx = idx; > } > > Modified: > head/sys/dev/extres/clk/clk.c Can you revert and recommit this with a proper log message? -- John Baldwin