From owner-freebsd-arch@FreeBSD.ORG  Tue Dec  2 09:31:19 2014
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4BA2E311
 for <arch@freebsd.org>; Tue,  2 Dec 2014 09:31:19 +0000 (UTC)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CF2BBCCC
 for <arch@freebsd.org>; Tue,  2 Dec 2014 09:31:18 +0000 (UTC)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id sB29VAkd016976
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 2 Dec 2014 11:31:10 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua sB29VAkd016976
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id sB29V9ei016972;
 Tue, 2 Dec 2014 11:31:09 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 2 Dec 2014 11:31:09 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Rui Paulo <rpaulo@me.com>
Subject: Re: Process reapers
Message-ID: <20141202093109.GG97072@kib.kiev.ua>
References: <20141201185237.GC97072@kib.kiev.ua>
 <2BBA8329-C8F4-452D-B6C2-E129FCD6D666@me.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2BBA8329-C8F4-452D-B6C2-E129FCD6D666@me.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home
Cc: arch@freebsd.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Dec 2014 09:31:19 -0000

On Mon, Dec 01, 2014 at 02:43:17PM -0800, Rui Paulo wrote:
> One comment I have is that we could rename the variables to something more meaningful instead of "p1" or "p2".  If "p1" is the reaper, we could call it "p_reaper".
> 
p_reaper is too confusing even to write, it is the same as the name
of the struct proc member.  p1/p2 is the pattern used in dofork(), so
I followed it for new code.

I could rename p1 to something else, but also short, since LIST_*
constructs are long and clumsy.  Might be, s/p1/rp/ ?