From owner-freebsd-virtualization@FreeBSD.ORG Wed Aug 27 18:17:06 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B48781065676 for ; Wed, 27 Aug 2008 18:17:06 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outS.internet-mail-service.net (outs.internet-mail-service.net [216.240.47.242]) by mx1.freebsd.org (Postfix) with ESMTP id C21428FC2E for ; Wed, 27 Aug 2008 18:17:05 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id E5EBB23FA; Wed, 27 Aug 2008 11:17:05 -0700 (PDT) Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id 4D4752D6083; Wed, 27 Aug 2008 11:17:05 -0700 (PDT) Message-ID: <48B59A26.7020907@elischer.org> Date: Wed, 27 Aug 2008 11:17:10 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707) MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <48B26560.4090303@ironport.com> <20080827171910.A66593@maildrop.int.zabbadoz.net> In-Reply-To: <20080827171910.A66593@maildrop.int.zabbadoz.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marko Zec , FreeBSD virtualization mailing list Subject: Re: progress toward next commit. X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2008 18:17:06 -0000 Bjoern A. Zeeb wrote: > On Mon, 25 Aug 2008, Julian Elischer wrote: > > Hi, > >> the branch vimage-commit2 contains my current candidate for commit. >> It has not been verified or reviewed by anyone else yet >> and I'm still working on it, so I expect changes. > > Can you let us know once you are 'done' (try to leave something for > the reviewers as well;-))? feel free to help :-) part of this commit is the adding of the actual vimage .h files and definitions... e.g. vinet.h and vnet.h, vinet6.h The definitions in these files could go in in.h in6.h and other places but there is some aesthetic reason for keeping them separate, and having them included at the end of each of those files as required.. currently I have: in.h includes vinet.h ip6.h includes vinet6.h and if.h includes vnet.h I chose these because it turns out that these files are already included in 98% of all teh files that need to iclude the vxxx.h files. so the actual .c files themselves don't need to include them To make this work I had to add #include if.h to exactly 3 files.. On further consideration I migh change those 3 files to just include directly without polluting themselves with if.h. While this adds a lot of vimage stuff that is not yet active, I feel it is better to get the files in now and shrink the remaining diff, and it still results in 0 actual code changes. > > Regards, > Bjoern >