From owner-svn-src-all@freebsd.org Tue Nov 13 00:49:36 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE39B112897C for ; Tue, 13 Nov 2018 00:49:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E80BF8C7FA for ; Tue, 13 Nov 2018 00:49:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io1-xd41.google.com with SMTP id u19so3387063ioc.2 for ; Mon, 12 Nov 2018 16:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E1PDfod6MjcRhFi3aZmxEAPiXfsAw4F8ezmRsghWj0g=; b=gzuQvb0d+DfzWD/psU1Pa59TZ8HnYqLowwFD4MRmMikow3yodeH7ckcrB4NvXvOnIr fSmjrMYuHGedQYDH2wWak8j51ruWqAG8bEu1fze3I5n2OwdiCR8v5MfezMwl0j3XP5wT Qj4CTMDkNE+kZL4bm2osAlstKKWdjgZRaT49PhNvmMglmmXK8s24cXH8WShoXq9IWa4L NE0mVUWYokyND8sYY2iw6caD6os79/RdlCBZyoQJ+zzSADOqapJI7c+k6F+vkw4lOD+g KTe4hx2NdvG6HuwZapr2Kwh0yCQLMgM5lIcpgrHxA65cgwFN9WulGtOUwiG1mDjfn65j EtfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E1PDfod6MjcRhFi3aZmxEAPiXfsAw4F8ezmRsghWj0g=; b=CBl/B7w2LtgOs0ASaXDF/zDXxRDxvKE8ZE0seLNz0esWDjI3DdP7R/p3lnsG/JNf2b MUWqJZx8QOiM+UeQizkKk2H5AnXlc+j2qxFYvBRhrR/7l1Vye96uO9Q0lM9Bq57ALkkO bZ3oyO85z7BGM9jR1PL+dlvUauVXBKwNbjKCXdX5p6yGWg3a3rT2/8e52x80IYuNzd8E 7sBkbBMp/P01rUnK/vKYyCKifcpy8QqaIdJK9H404+s0Hr8eacMH4MiS45E9ICrP6g5C iyRaOHmD9StrDcsoEgIcaXj2r36xwFRmDkIpfCMsUjvwNG4pkLdA4pUGcONjGOncf9fr xuiA== X-Gm-Message-State: AGRZ1gIT0pvGptJKlOt286pAiBl9zm1p6YL5owFsDAtQNnrukEjQ/C3Z et+mxMH5ZZ3+80FewFf06JqkoFIX7MSDMAhx53YIdV9F X-Google-Smtp-Source: AJdET5daZAnnBD/Gcu94xO6d9Ukd3pfHbooUof1Am7mGt2GUvBlbAPuu/0tEhpfMvvdG+mH0XDG1EYds+nMU6R6i8xg= X-Received: by 2002:a5e:8614:: with SMTP id z20-v6mr2548130ioj.37.1542070175025; Mon, 12 Nov 2018 16:49:35 -0800 (PST) MIME-Version: 1.0 References: <201811130030.wAD0U6sG028350@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201811130030.wAD0U6sG028350@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Mon, 12 Nov 2018 17:49:24 -0700 Message-ID: Subject: Re: svn commit: r340387 - in head/sys: amd64/conf i386/conf To: "Rodney W. Grimes" Cc: Niclas Zeising , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: E80BF8C7FA X-Spamd-Result: default: False [-3.94 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[1.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.94)[-0.943,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.99)[ipnet: 2607:f8b0::/32(-2.90), asn: 15169(-1.93), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 00:49:37 -0000 On Mon, Nov 12, 2018 at 5:30 PM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Mon, Nov 12, 2018, 3:12 PM Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net wrote: > > > > > > Author: zeising (doc,ports committer) > > > > Date: Mon Nov 12 21:01:28 2018 > > > > New Revision: 340387 > > > > URL: https://svnweb.freebsd.org/changeset/base/340387 > > > > > > > > Log: > > > > Add evdev support to amd64 and i386 kernels > > > > > > > > Include evdev support and drivers in the amd64 and i386 GENERIC and > > > MINIMAL > > > > kernels. Evdev is used by X and wayland to handle input devices, > and > > > this > > > > change, together with upcomming changes in ports will make us > handle > > > input > > > > devices better in graphical UIs. > > > > > > Well these "upcomming" changes in ports effect aarch64 and powerpc > > > who are also consumers of X? > > > > > > > Likely. Though there is little experience with them, so we don't know if > it > > is even safe to turn them on there yet. This has taken 6 months to get > > stable on x86 due to its fragile console locking protocol. Similar time > has > > not been invested elsewhere, so until that happens, we should keep them > off > > by default. Otherwise we run the risk of destabilizing these platforms, > > even for people who don't use X. As tier 2 platforms, this has been how > > we've traditionally approached risk. Even though aarch64 is approaching > > tier1 status overall, in graphics it is still lagging. > > From some place aarch64 is already a tier1 platform, specifically > it is listed as such in the pkg.freebsd.org package download page. > Graphics on aarch64 is tier 2, and will remain tier 2 for the foreseeable future. Tier 1 support requires that we leverage other people's drivers, and we can't easily do that w/o a good linux compat layer. The structure of FreeBSD and Linux are just enough different that doing so is somewhat tricky and labor intensive. This is especially true for the acceleration features. Basic framebuffer support isn't terribly hard, but to get good 2d and 3d acceleration, we'll likely need to run upstream vendor's code (which in many cases is available only as a binary blob + linux glue). > My real concern here is that it sounded like changes to what are > in the ports/packages are going to be made in such a way that you > are required to have evdev to use them. If this suddently becomes > mandatory to be able to use X we need to ensure that this code > (evdev) does infact work on aarch64 and others before such changes are > put in place. My reading here is that this code is only avaliable > as static compile into the kernel, aka no moduleto load, making this > a non-trivial road block to rpi3, etc users. > This is just for touchscreen support on x86, which requires evdev to work well. Whatever works today won't change. However, without a lot of testing, I'm hesitant to blindly enable it on aarch64. Once that changes, we can turn it on, but until then it would be unwise. And evdev can be turned off on a per-platform basis in the packages / ports tree should the need arise. I don't think this is going to be an issue. Warner > > Warner > > > > > > > Reviewed by: wulf, bapt, imp > > > > Approved by: imp > > > > Differential Revision: https://reviews.freebsd.org/D17912 > > > > > > > > Modified: > > > > head/sys/amd64/conf/GENERIC > > > > head/sys/amd64/conf/MINIMAL > > > > head/sys/i386/conf/GENERIC > > > > head/sys/i386/conf/MINIMAL > > > > > > > > Modified: head/sys/amd64/conf/GENERIC > > > > > > > > ============================================================================== > > > > --- head/sys/amd64/conf/GENERIC Mon Nov 12 20:44:22 2018 > > > (r340386) > > > > +++ head/sys/amd64/conf/GENERIC Mon Nov 12 21:01:28 2018 > > > (r340387) > > > > @@ -372,3 +372,8 @@ device vmx # > VMware > > > VMXNET3 Ethernet > > > > > > > > # Netmap provides direct access to TX/RX rings on supported NICs > > > > device netmap # netmap(4) support > > > > + > > > > +# evdev interface > > > > +options EVDEV_SUPPORT # evdev support in legacy > drivers > > > > +device evdev # input event device > > > support > > > > +device uinput # install /dev/uinput > cdev > > > > > > > > Modified: head/sys/amd64/conf/MINIMAL > > > > > > > > ============================================================================== > > > > --- head/sys/amd64/conf/MINIMAL Mon Nov 12 20:44:22 2018 > > > (r340386) > > > > +++ head/sys/amd64/conf/MINIMAL Mon Nov 12 21:01:28 2018 > > > (r340387) > > > > @@ -147,3 +147,8 @@ device bpf # > Berkeley > > > packet filter > > > > # NOTE: XENHVM depends on xenpci. They must be added or removed > > > together. > > > > options XENHVM # Xen HVM kernel infrastructure > > > > device xenpci # Xen HVM Hypervisor > > > services driver > > > > + > > > > +# evdev interface > > > > +options EVDEV_SUPPORT # evdev support in legacy > drivers > > > > +device evdev # input event device > > > support > > > > +device uinput # install /dev/uinput > cdev > > > > > > > > Modified: head/sys/i386/conf/GENERIC > > > > > > > > ============================================================================== > > > > --- head/sys/i386/conf/GENERIC Mon Nov 12 20:44:22 2018 > > > (r340386) > > > > +++ head/sys/i386/conf/GENERIC Mon Nov 12 21:01:28 2018 > > > (r340387) > > > > @@ -366,3 +366,8 @@ device xenpci # Xen > HVM > > > Hypervisor services driver > > > > > > > > # VMware support > > > > device vmx # VMware VMXNET3 > Ethernet > > > > + > > > > +# evdev interface > > > > +options EVDEV_SUPPORT # evdev support in legacy > drivers > > > > +device evdev # input event device > > > support > > > > +device uinput # install /dev/uinput > cdev > > > > > > > > Modified: head/sys/i386/conf/MINIMAL > > > > > > > > ============================================================================== > > > > --- head/sys/i386/conf/MINIMAL Mon Nov 12 20:44:22 2018 > > > (r340386) > > > > +++ head/sys/i386/conf/MINIMAL Mon Nov 12 21:01:28 2018 > > > (r340387) > > > > @@ -148,3 +148,8 @@ device bpf # > Berkeley > > > packet filter > > > > # NOTE: XENHVM depends on xenpci. They must be added or removed > > > together. > > > > options XENHVM # Xen HVM kernel infrastructure > > > > device xenpci # Xen HVM Hypervisor > > > services driver > > > > + > > > > +# evdev interface > > > > +options EVDEV_SUPPORT # evdev support in legacy > drivers > > > > +device evdev # input event device > > > support > > > > +device uinput # install /dev/uinput > cdev > > > > > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > > > > -- > Rod Grimes > rgrimes@freebsd.org >