From nobody Sun Apr 27 15:38:46 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZlrNG4t7tz5v06h for ; Sun, 27 Apr 2025 15:39:10 +0000 (UTC) (envelope-from dch@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZlrNG1cbmz3lY8; Sun, 27 Apr 2025 15:39:10 +0000 (UTC) (envelope-from dch@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745768350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aYcVR0W6YMmK6q628jY5cP+n3wkd3fWuOdSMnf2V5uc=; b=ZB1zlA6DjLfW20Otsp44Xg5b4K7nxzpSsRdqNRGI7e+XCdyWLDCZf1g9+X6lELqqFspRWA 2wVP6C/p5FLyqoeAsfH/sK9LLLom+YMNIZzRFoqnAjNd7Bt9El2pnFVK+is+V7syNLOoKJ NS5zkUaaSrUIaa1L1E20Qv1aRtUmmj5AaFAlwvOVl3RoOv59wuA5dKb30tTMI9pNDJS0mu 7pSRtcQ5ZHe1ObEcQGBoVZbxsHJFQZRixqOYMURlrDy4OojrhckEw1H7cz9nHgJbY7nC1n g8CtbdclwtBKgsJ0ibvPhByuQpanmnxIlpyRAdK7VMzwd9gWUkuW8BObx7U8CA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745768350; a=rsa-sha256; cv=none; b=dDu8SSWoCTtvH/qmhDo0cAvO4IkLRHWeMNNi/bEv2YswBHq6oXwaUA+mktAtovP1g0Cdf+ w1OuxHXhNIxOY5A+e3hnPxH8qwbxeHb+43CTW1eLqfMpy9GF679ppIi3o4DPfqtqYO8sZf UKkK179sE/DHidOBqfE+i0MjBpZ5mmTgl92cLMvnIMBryIvzxoswAtPXRo1FWWDN5o/d1U PKAosYYNnsCe3KI1eFK4ROVsmuXd0Gds0yo4dIrTTb6SgR6wy/PVwn2b//x5TvNUQhKIbE pZDlSuWA2NOUCA9G4zGrYLvQ3jVOr9bcBaDbPPfjLcvui9AQmpnT6T5pPx6Tyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745768350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aYcVR0W6YMmK6q628jY5cP+n3wkd3fWuOdSMnf2V5uc=; b=f8Rb9LB7KHan/qLcY2HX0JeLbcgyZZ2ZBuULunS2AeuRNTUJ6WmxAzRDLlk0DwQo50Y8dr qLMrbizcEtCQI7rfi01HNlns0VtzHRBb6kfoQVk1TeLvG71XHP2bRhIv8NQ4FajFqhcOki CNcrrhtaJdi7ov30uUd5QAWT7mRKkDEPDc+gYXo+GjOGtqHaEUYoOJ+N3xwsodWlwPVBCw nM40NMx2uby2imFm8QBeCQPITzu1Mo8aFrAsba2ph09xo/Emi6Z4eIxx2P+5hRKMJtbqDd k7tLtynKEmnVd7M5D5Uf3Yw6/g1Fdn3SnYa9fjPkC2hRk5vIYa1f9XxtEUBW4A== Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com [103.168.172.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: dch/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZlrNG0nBKzLn3; Sun, 27 Apr 2025 15:39:10 +0000 (UTC) (envelope-from dch@FreeBSD.org) Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfauth.phl.internal (Postfix) with ESMTP id 683E1120007C; Sun, 27 Apr 2025 11:39:06 -0400 (EDT) Received: from phl-imap-16 ([10.202.2.88]) by phl-compute-02.internal (MEProxy); Sun, 27 Apr 2025 11:39:06 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvheekgeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefogg ffhffvvefkjghfufgtgfesthhqredtredtjeenucfhrhhomhepfdffrghvvgcuvehothht lhgvhhhusggvrhdfuceouggthheshfhrvggvuefuffdrohhrgheqnecuggftrfgrthhtvg hrnhepfeekfedttdevheefffevudevtdeuiefffefhjeejveegvdegtdffieduteehvedu necuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepuggthhdomhgvshhmthhprghuthhhphgvrhhs ohhnrghlihhthidquddvgeeluddtfeeguddquddvudefuddujeejqdgutghhpeephfhrvg gvuefuffdrohhrghesfhgrshhtmhgrihhlrdhfmhdpnhgspghrtghpthhtohepfedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepfhhrvggvsghsugdqtghurhhrvghnthesfh hrvggvsghsugdrohhrghdprhgtphhtthhopehglhgvsghiuhhssehfrhgvvggsshgurdho rhhgpdhrtghpthhtohepfihulhhfsehfrhgvvggsshgurdhorhhg X-ME-Proxy: Feedback-ID: icedc46df:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 41E072CC006B; Sun, 27 Apr 2025 11:39:06 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 X-ThreadId: T7d8fb190958b0cc3 Date: Sun, 27 Apr 2025 15:38:46 +0000 From: "Dave Cottlehuber" To: "Vladimir Kondratyev" Cc: freebsd-current , "Gleb Smirnoff" Message-Id: In-Reply-To: <7c4e115c-f0a5-4462-a34f-38291770aa92@FreeBSD.org> References: <447332f8-a8bc-4b90-a605-4c705a58f491@app.fastmail.com> <4aad4a70-a953-458b-ac37-675b6901f28c@app.fastmail.com> <7c4e115c-f0a5-4462-a34f-38291770aa92@FreeBSD.org> Subject: Re: April 2025 stabilization week Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, 26 Apr 2025, at 16:19, Vladimir Kondratyev wrote: > On 4/24/25 21:46, Gleb Smirnoff wrote: >> On Thu, Apr 24, 2025 at 05:48:46PM +0000, Dave Cottlehuber wrote: >> D> On Thu, 24 Apr 2025, at 17:31, Gleb Smirnoff wrote: >> D> > D> This issue actually came up last month but I had no time to >> D> > investigate >> D> > D> then, details >> D> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D286045 >> D> > >> D> > Is this regression since last stabweek or from an earlier point? >> D> >> D> Just since March stabweek. >>=20 >> There were no changes to the driver :( >>=20 >> Any chance you can make a bisect? >>=20 > > I think it is regression from daa098cc37b9 > > Test this patch: > > diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c > index eeabf817616..d82beb52d58 100644 > --- a/sys/dev/iicbus/iichid.c > +++ b/sys/dev/iicbus/iichid.c > @@ -630,7 +630,7 @@ iichid_intr(void *context) > error =3D iichid_cmd_read(sc, sc->intr_buf, sc->intr_bufsize, &actu= al); > THREAD_NO_SLEEPING(); > if (error =3D=3D 0) { > - if (sc->power_on) { > + if (sc->power_on && sc->open) { > if (actual !=3D 0) > sc->intr_handler(sc->intr_ctx, sc->intr_buf, > actual); > --=20 > WBR > Vladimir Kondratyev \o/ works perfectly, thanks Vladimir!=20 A+ Dave =E2=80=94=E2=80=94=E2=80=94 O for a muse of fire, that would ascend the brightest heaven of inventio= n!