From owner-freebsd-multimedia@FreeBSD.ORG  Thu Apr  1 11:40:07 2010
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0AFC0106564A
	for <freebsd-multimedia@hub.freebsd.org>;
	Thu,  1 Apr 2010 11:40:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D401B8FC12
	for <freebsd-multimedia@hub.freebsd.org>;
	Thu,  1 Apr 2010 11:40:06 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o31Be6NB023449
	for <freebsd-multimedia@freefall.freebsd.org>;
	Thu, 1 Apr 2010 11:40:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o31Be6JG023448;
	Thu, 1 Apr 2010 11:40:06 GMT (envelope-from gnats)
Date: Thu, 1 Apr 2010 11:40:06 GMT
Message-Id: <201004011140.o31Be6JG023448@freefall.freebsd.org>
To: freebsd-multimedia@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/98167: commit references a PR
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2010 11:40:07 -0000

The following reply was made to PR kern/98167; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/98167: commit references a PR
Date: Thu,  1 Apr 2010 11:31:01 +0000 (UTC)

 Author: joel (doc committer)
 Date: Thu Apr  1 11:30:46 2010
 New Revision: 206033
 URL: http://svn.freebsd.org/changeset/base/206033
 
 Log:
   Fix the gap between mute and lowest possible volume. The es1370 mixer
   volumes were incorrectly calculated.
   
   I've tested this with one of my es1370 cards and I can confirm that it
   works.
   
   PR:		98167
   Submitted by:	Joseph Terner <jtsn@gmx.de>
   Approved by:	kib
 
 Modified:
   head/sys/dev/sound/pci/es137x.c
 
 Modified: head/sys/dev/sound/pci/es137x.c
 ==============================================================================
 --- head/sys/dev/sound/pci/es137x.c	Thu Apr  1 10:41:01 2010	(r206032)
 +++ head/sys/dev/sound/pci/es137x.c	Thu Apr  1 11:30:46 2010	(r206033)
 @@ -355,7 +355,7 @@ es1370_mixset(struct snd_mixer *m, unsig
  	if (mixtable[dev].left == 0xf)
  		rl = (l < 2) ? 0x80 : 7 - (l - 2) / 14;
  	else
 -		rl = (l < 10) ? 0x80 : 15 - (l - 10) / 6;
 +		rl = (l < 7) ? 0x80 : 31 - (l - 7) / 3;
  	es = mix_getdevinfo(m);
  	ES_LOCK(es);
  	if (dev == SOUND_MIXER_PCM && (ES_SINGLE_PCM_MIX(es->escfg)) &&
 @@ -364,7 +364,7 @@ es1370_mixset(struct snd_mixer *m, unsig
  	else
  		set_dac1 = 0;
  	if (mixtable[dev].stereo) {
 -		rr = (r < 10) ? 0x80 : 15 - (r - 10) / 6;
 +		rr = (r < 7) ? 0x80 : 31 - (r - 7) / 3;
  		es1370_wrcodec(es, mixtable[dev].right, rr);
  		if (set_dac1 && mixtable[SOUND_MIXER_SYNTH].stereo)
  			es1370_wrcodec(es,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"