From owner-cvs-ports@FreeBSD.ORG Tue Aug 23 07:40:46 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7FA91065675; Tue, 23 Aug 2011 07:40:46 +0000 (UTC) (envelope-from pawelbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id DCAB98FC13; Tue, 23 Aug 2011 07:40:45 +0000 (UTC) Received: by fxe4 with SMTP id 4so88233fxe.13 for ; Tue, 23 Aug 2011 00:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; bh=m7Ydd0wdVkvMiCF6hsL/5UDl4blUmZ2J46GyAt22OAQ=; b=tcEcxKmEY11TIEDm2zPK21qilzX4hZD1wBDwRQot9sTFrwBRFV2ucQv+Cee2HAqpm7 OXYR92byJIkT+2OAmgavyu1SiymVTF4GP6S9VXWpO9HKAusr5UzdXONqWbHD2AX2PwDO oLn84SgpALqofoOL+/mhDqcuXk+ACn3Ds19Tw= Received: by 10.223.5.209 with SMTP id 17mr4981895faw.109.1314083679577; Tue, 23 Aug 2011 00:14:39 -0700 (PDT) Received: from unknown (apf3.neoplus.adsl.tpnet.pl [83.26.139.3]) by mx.google.com with ESMTPS id 22sm5719253fat.17.2011.08.23.00.14.38 (version=SSLv3 cipher=OTHER); Tue, 23 Aug 2011 00:14:39 -0700 (PDT) Sender: =?UTF-8?B?UGF3ZcWCIFDEmWthbGE=?= Date: Tue, 23 Aug 2011 09:13:26 +0200 From: =?ISO-8859-2?Q?Pawe=B3_P=EAkala?= To: Alexey Dokuchaev Message-ID: <20110823091326.00002064@unknown> In-Reply-To: <20110823020838.GA96726@FreeBSD.org> References: <201108221821.p7MILBln038468@repoman.freebsd.org> <20110823020838.GA96726@FreeBSD.org> X-Mailer: Claws Mail 3.7.8cvs63 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/polish/kadu Makefile distinfo pkg-descr pkg-plist ports/polish/kadu/files patch-kadu-core__CMakeLists.txt patch-kadu-core_gadu_resolver.cpp patch-modules__docking__CMakeLists.txt patch-modules__idle__CMakeLists.txt patch-modules__kde_notify__CMakeLists.txt patch-modules__screenshot__CMakeLists.txt patch-modules__sound__CMakeLists.txt ... X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2011 07:40:46 -0000 Dnia , o godz.=20 Alexey Dokuchaev napisa=B3(a): > Still some issues with this port: Thanks for your suggestions, I`m new here so they will help me improve my contributions. Firstly I want to say that this is situation where I was taking over maintaniership so there were two people (me and former maintainer) working on update so different "styles" got mixed etc. > - First part of the makefile (delarative one) is badly indented; > indentation should be reduced my one tabstop Sometimes more indentation help readability, in this case you are right it's too many ;-) When submitting updates to other people's ports my rule is always to stick to their style of indentation, it may look messy to me but may work for maintainer. > - Bad spelling of Qt toolkit in COMMENT (it looks like port is > QuickTime based now); also, " / " does not look too good, simple > "and" would look better Good catch. Project description is now "Internet Communicator" as they gained ability to connect Jabber network so I can use this. =20 > %%% > LIB_DEPENDS=3D enchant.1:${PORTSDIR}/textproc/enchant \ > gadu.3:${PORTSDIR}/polish/libgadu \ > + idn:${PORTSDIR}/dns/libidn \ > qca.2:${PORTSDIR}/devel/qca \ > sndfile.1:${PORTSDIR}/audio/libsndfile > %%% >=20 > Missing shlib version (notice that other libs have it). While it > technically not required, it's nice to have to be able to grep for > when buming port revision of library consumer ports to chase shlib > version bumps. While I am with Doug at this one things could be more consistent - if there are shlib versions they should be on all dependencies. According to upstream version 0.10.0 will be released soon, I will incorporate all mentioned things in that update. Pawe=B3