From nobody Mon Jul 28 13:31:42 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4brKBm1nq1z63545; Mon, 28 Jul 2025 13:31:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4brKBk6mDQz3vgD; Mon, 28 Jul 2025 13:31:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/8brrLhrjlEyCwsigEwrTiLBUlYOiqnHq2LPsz1+OtQ=; b=TTSVX8ZZMY9mHsUQmmvusaBKcuZMPesMotTKeUEP1HMkl2B9PR6rSHwwYbt1tzVha2ppex Z7PKD5JfSrRP0r5vsIglrZ0z+VA9/gwSsO9gGwmZZnITbX4XAliXsOlwUiESzu26345jnJ hMm4IpTEHrlcwIp7L0X3p8vaS9Lc844N0AvYg+Qd89j4ykYb/qOdUcdwUEtNaQwBz5TqIK rQdCNEb0JObqb0cmxNqj2eY3g9wYM2jlYX6NkPAZt02vqwXiFcX6JHKY27Md1Oom+6eQPM zRgsDLT/Zx5uAE21foGok4xbDnWCYjMLJXU2V32U+kg0SfJWTMq1v+eUPJRJfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/8brrLhrjlEyCwsigEwrTiLBUlYOiqnHq2LPsz1+OtQ=; b=aoPlj2qvCN3Xqa+giTK4a5naxyfyDhSMwcFXfFhvFVangjZW58VOFfzdWl7KltStjvQuoD R2m60XumbLlTbQABFcHHnxl3usgVwYaculctNyw2WtjtQ/x8Q1wBSWc88pEqAJZUtZidhR f6ZzJ7HRTUFiCfgy7dAyRYh8+ynryPAwHhuyfADMeQtcxaPd/TXZmOJQLs2BjveOUt7UZP 75y5H8xOgo5l2fxcEzs95VzRbXAj5vL9qzpbyNH/MigyNANGIp3ivGjs1ePARE102clIwV 5y9JMe9vEAhJYmT9LY4In1R7b4b5UdwZzHkWYULOBmv6Aahn4bdCzNDEsnmtrw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753709502; a=rsa-sha256; cv=none; b=MSMRsRXHxWqVpLntPSIhud7ONpL7YB89xC6O8qAXpcIzpTHhi/9aE44U4wVWwYFejJZSBd ypV1vTd5mg10z/wcOu44pg2v9yK/xWcmyVd6qylF3Jf+kkWwVNB7Ie55cLvsYDdgWLYBoI RleNKEXeHBocVniv8umQwsb9zgoMBZF8WtnUEH63lPdvfDMsLqxh/4IevS8bRY/u/YY+Qb 1BQG5eQQoXVcNtaxgokfZLev9LPOHP9LKDLTdpvegq3AzZakAFfJpiHZDzCtrXt7IJLgc7 w3HXFFWrGfGCIDtRZR/DQnCKx65dvsdDt61XjDDKzsNLvk86n1r6l3KVfhMTQg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4brKBk69zZznRY; Mon, 28 Jul 2025 13:31:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56SDVgAt082263; Mon, 28 Jul 2025 13:31:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56SDVgXX082260; Mon, 28 Jul 2025 13:31:42 GMT (envelope-from git) Date: Mon, 28 Jul 2025 13:31:42 GMT Message-Id: <202507281331.56SDVgXX082260@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 8a59ea47d92c - stable/14 - sched_ule: 32-bit platforms: Fix runq_print() after runq changes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8a59ea47d92c3c4b6dca61a3c21346ae34b30b61 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=8a59ea47d92c3c4b6dca61a3c21346ae34b30b61 commit 8a59ea47d92c3c4b6dca61a3c21346ae34b30b61 Author: Olivier Certner AuthorDate: 2025-06-18 15:15:18 +0000 Commit: Olivier Certner CommitDate: 2025-07-28 13:28:44 +0000 sched_ule: 32-bit platforms: Fix runq_print() after runq changes The compiler would report a mismatch between the format and the actual type of the runqueue status word because the latter is now unconditionally defined as an 'unsigned long' (which has the "natural" platform size) and the format expects a 'size_t', which expands to an 'unsigned int' on 32-bit platforms (although they are both of the same actual size). This worked before as the C type used depended on the architecture and was set to 'uint32_t' aka 'unsigned int' on these 32-bit platforms. Just fix the format (use 'l'). While here, remove outputting '0x' by hand, instead relying on '#' (only difference is for 0, and is fine). runq_print() should be moved out of 'sched_ule.c' in a subsequent commit. Reported by: Jenkins Fixes: 79d8a99ee583 ("runq: Deduce most parameters, remove machine headers") MFC after: 1 month Event: Kitchener-Waterloo Hackathon 202506 Sponsored by: The FreeBSD Foundation (cherry picked from commit 013c58ced6aef26bad7ca5c6eb829b9d586f6edb) --- sys/kern/sched_ule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index b09d6dfc0f54..f59b7195f754 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -444,7 +444,7 @@ runq_print(struct runq *rq) int i; for (i = 0; i < RQSW_NB; i++) { - printf("\t\trunq bits %d 0x%zx\n", + printf("\t\trunq bits %d %#lx\n", i, rq->rq_status.rq_sw[i]); for (j = 0; j < RQSW_BPW; j++) if (rq->rq_status.rq_sw[i] & (1ul << j)) {