Date: Mon, 29 Aug 2016 21:16:29 +0300 From: Andrey Chernov <ache@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com>, John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304928 - in head/lib/libc: amd64/sys i386/sys sys Message-ID: <a6921ce6-ca99-6ee9-24de-fe90a440879d@freebsd.org> In-Reply-To: <20160829180454.GU83214@kib.kiev.ua> References: <201608272303.u7RN3N0D078505@repo.freebsd.org> <1595604.93PBdSz0kX@ralph.baldwin.cx> <20160829065813.GP83214@kib.kiev.ua> <18206408.GMLM77D01s@ralph.baldwin.cx> <20160829180454.GU83214@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29.08.2016 21:04, Konstantin Belousov wrote: > On Mon, Aug 29, 2016 at 08:46:47PM +0300, Andrey Chernov wrote: >> Either we implement this wrapper or left all things as is, we need to >> document internal errno clearing additionally, to not make people wonder >> why errno becomes 0, probably with the mention that program should not >> relay on this obsoleted implementation feature. > It was done in r304928. John want to revert this change, it seems. > Previous text is documented everywhere and describing usual good practice, so it should remains in place, in that means r304928 should be reverted, because replace proper way of doing things with obsoleted feature description. What I suggest is not _replace_ old text with new, but _add_ new text as describing current and not recommended way, with the direct mention that this feature is obsoleted and not recommended for relay on it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a6921ce6-ca99-6ee9-24de-fe90a440879d>